From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v7 RESEND Rebased] btrfs-progs: dump-tree: add noscan option
Date: Thu, 4 Jul 2019 06:16:54 +0800 [thread overview]
Message-ID: <EFB71435-3B86-46A8-90A1-9DCA2BEFF934@oracle.com> (raw)
In-Reply-To: <20190703160907.GW20977@twin.jikos.cz>
> On 4 Jul 2019, at 12:09 AM, David Sterba <dsterba@suse.cz> wrote:
>
> On Wed, Jun 26, 2019 at 01:30:17AM -0700, Anand Jain wrote:
>> From: Anand Jain <Anand.Jain@oracle.com>
>>
>> The cli 'btrfs inspect dump-tree <dev>' will scan for the partner devices
>> if any by default.
>>
>> So as of now you can not inspect each mirrored device independently.
>>
>> This patch adds noscan option, which when used won't scan the system for
>> the partner devices, instead it just uses the devices provided in the
>> argument.
>>
>> For example:
>> btrfs inspect dump-tree --noscan <dev> [<dev>..]
>>
>> This helps to debug degraded raid1 and raid10.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>
> This makes misc-test/021-image-multi-devices fail
>
> ====== RUN CHECK root_helper mount /dev/loop2 .../btrfs-progs/tests//mnt
> ====== RUN CHECK md5sum .../btrfs-progs/tests//mnt/foobar
> md5sum: .../btrfs-progs/tests//mnt/foobar: Input/output error
> failed: md5sum .../btrfs-progs/tests//mnt/foobar
> ====== RUN CHECK root_helper umount .../btrfs-progs/tests//mnt
> ====== RUN CHECK root_helper losetup -d /dev/loop2
> ====== RUN CHECK root_helper losetup -d /dev/loop3
>
> note the md5sum error, that does not happen otherwise
I am on devel. It runs fine. Test-misc/021 doesn’t use dump-tree at all.
Its strange that mnt/foobar fails to read in your case.
----
[root@dvm btrfs-progs]# make TEST=021\* test-misc
[LD] fssum
[TEST] misc-tests.sh
[TEST/misc] 021-image-multi-devices
[root@dvm btrfs-progs]#
[root@dvm btrfs-progs]#
[root@dvm btrfs-progs]#
[root@dvm btrfs-progs]# gl | head -1
299892f3c43d btrfs-progs: dump-tree: add noscan option
[root@dvm btrfs-progs]# make all
make: Nothing to be done for `all'.
[root@dvm btrfs-progs]#
------
next prev parent reply other threads:[~2019-07-03 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 8:30 [PATCH v7 RESEND Rebased] btrfs-progs: dump-tree: add noscan option Anand Jain
2019-07-02 8:09 ` Anand Jain
2019-07-03 12:53 ` David Sterba
2019-07-03 13:02 ` David Sterba
2019-07-03 16:09 ` David Sterba
2019-07-03 22:16 ` Anand Jain [this message]
2019-07-03 23:39 ` David Sterba
2019-07-04 1:29 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EFB71435-3B86-46A8-90A1-9DCA2BEFF934@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).