From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Nikolay Borisov <nborisov@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 4/4] btrfs: Don't opencode sync_blockdev
Date: Wed, 22 Jul 2020 09:20:08 +0000 [thread overview]
Message-ID: <SN4PR0401MB3598C025490C82DCA8AC408E9B790@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200722080925.6802-5-nborisov@suse.com
On 22/07/2020 10:09, Nikolay Borisov wrote:
> Instead of opencoding filemap_write_and_wait simply call syncblockdev as
sync_blockdev() ~^
> it makes it abundandtly clear what's going on and why this is used. No
abundantly ~^
Otherwise:
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
next prev parent reply other threads:[~2020-07-22 9:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 8:09 [PATCH 0/4] Misc cleanups around device addition Nikolay Borisov
2020-07-22 8:09 ` [PATCH 1/4] btrfs: Use rcu when iterating devices in btrfs_init_new_device Nikolay Borisov
2020-07-22 9:17 ` Johannes Thumshirn
2020-07-22 10:36 ` Nikolay Borisov
2020-07-22 14:47 ` David Sterba
2020-07-22 14:53 ` Johannes Thumshirn
2020-07-23 7:45 ` Nikolay Borisov
2020-07-22 8:09 ` [PATCH 2/4] btrfs: Refactor locked condition " Nikolay Borisov
2020-07-30 4:31 ` Anand Jain
2020-07-22 8:09 ` [PATCH 3/4] btrfs: Remove redundant code from btrfs_free_stale_devices Nikolay Borisov
2020-07-30 5:01 ` Anand Jain
2020-07-22 8:09 ` [PATCH 4/4] btrfs: Don't opencode sync_blockdev Nikolay Borisov
2020-07-22 9:20 ` Johannes Thumshirn [this message]
2020-07-30 5:05 ` Anand Jain
2020-08-26 16:07 ` [PATCH 0/4] Misc cleanups around device addition Nikolay Borisov
2020-08-28 15:48 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB3598C025490C82DCA8AC408E9B790@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).