From: Nathan Chancellor <nathan@kernel.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com, llvm@lists.linux.dev
Subject: Re: [PATCH 8/8] btrfs: turn on -Wmaybe-uninitialized
Date: Sun, 25 Dec 2022 21:17:11 -0700 [thread overview]
Message-ID: <Y6kgR4qnb23UdAEX@dev-arch.thelio-3990X> (raw)
In-Reply-To: <1d9deaa274c13665eca60dee0ccbc4b56b506d06.1671221596.git.josef@toxicpanda.com>
On Fri, Dec 16, 2022 at 03:15:58PM -0500, Josef Bacik wrote:
> We had a recent bug that would have been caught by a newer compiler with
> -Wmaybe-uninitialized and would have saved us a month of failing tests
> that I didn't have time to investigate.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
This needs to be moved to the condflags section, as
-Wmaybe-uninitialized is a GCC only flag, so this breaks our builds with
clang on next-20221226:
error: unknown warning option '-Wmaybe-uninitialized'; did you mean '-Wuninitialized'? [-Werror,-Wunknown-warning-option]
I can send a patch on Tuesday unless the original commit can be amended.
> ---
> fs/btrfs/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/Makefile b/fs/btrfs/Makefile
> index 555c962fdad6..eca995abccdf 100644
> --- a/fs/btrfs/Makefile
> +++ b/fs/btrfs/Makefile
> @@ -7,6 +7,7 @@ subdir-ccflags-y += -Wmissing-format-attribute
> subdir-ccflags-y += -Wmissing-prototypes
> subdir-ccflags-y += -Wold-style-definition
> subdir-ccflags-y += -Wmissing-include-dirs
> +subdir-ccflags-y += -Wmaybe-uninitialized
> condflags := \
> $(call cc-option, -Wunused-but-set-variable) \
> $(call cc-option, -Wunused-const-variable) \
> --
> 2.26.3
>
>
next prev parent reply other threads:[~2022-12-26 4:17 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 20:15 [PATCH 0/8] Fixup uninitialized warnings and enable extra checks Josef Bacik
2022-12-16 20:15 ` [PATCH 1/8] btrfs: fix uninit warning in run_one_async_start Josef Bacik
2022-12-17 0:15 ` Qu Wenruo
2022-12-19 7:51 ` Johannes Thumshirn
2022-12-20 19:03 ` David Sterba
2022-12-21 18:26 ` David Sterba
2022-12-16 20:15 ` [PATCH 2/8] btrfs: fix uninit warning in btrfs_cleanup_ordered_extents Josef Bacik
2022-12-17 0:16 ` Qu Wenruo
2022-12-19 7:53 ` Johannes Thumshirn
2022-12-16 20:15 ` [PATCH 3/8] btrfs: fix uninit warning from get_inode_gen usage Josef Bacik
2022-12-17 0:16 ` Qu Wenruo
2022-12-19 7:55 ` Johannes Thumshirn
2022-12-20 19:16 ` David Sterba
2022-12-16 20:15 ` [PATCH 4/8] btrfs: fix uninit warning in btrfs_update_block_group Josef Bacik
2022-12-17 0:16 ` Qu Wenruo
2022-12-19 7:56 ` Johannes Thumshirn
2022-12-16 20:15 ` [PATCH 5/8] btrfs: fix uninit warning in __set_extent_bit and convert_extent_bit Josef Bacik
2022-12-17 0:17 ` Qu Wenruo
2022-12-16 20:15 ` [PATCH 6/8] btrfs: extract out zone cache usage into it's own helper Josef Bacik
2022-12-19 7:05 ` Naohiro Aota
2022-12-20 19:24 ` David Sterba
2022-12-21 16:47 ` Naohiro Aota
2022-12-21 18:08 ` David Sterba
2022-12-16 20:15 ` [PATCH 7/8] btrfs: fix uninit warning in btrfs_sb_log_location Josef Bacik
2022-12-19 6:23 ` Naohiro Aota
2022-12-19 7:59 ` Johannes Thumshirn
2022-12-16 20:15 ` [PATCH 8/8] btrfs: turn on -Wmaybe-uninitialized Josef Bacik
2022-12-17 0:18 ` Qu Wenruo
2022-12-26 4:17 ` Nathan Chancellor [this message]
2022-12-26 14:04 ` Naresh Kamboju
2023-01-02 12:42 ` David Sterba
2023-02-22 2:59 ` Guenter Roeck
2023-02-22 16:38 ` David Sterba
2023-02-22 17:18 ` Guenter Roeck
2023-03-12 13:06 ` Linux regression tracking (Thorsten Leemhuis)
2023-03-12 14:37 ` Guenter Roeck
2023-03-12 14:57 ` Linux regression tracking (Thorsten Leemhuis)
2023-03-26 18:03 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-03-14 21:59 ` David Sterba
2023-02-24 17:22 ` Guenter Roeck
2022-12-16 23:55 ` [PATCH 0/8] Fixup uninitialized warnings and enable extra checks Qu Wenruo
2022-12-17 0:07 ` Qu Wenruo
2022-12-20 19:37 ` David Sterba
2022-12-21 18:36 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6kgR4qnb23UdAEX@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).