From: Matthew Wilcox <willy@infradead.org>
To: dsterba@suse.cz, fdmanana@kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] btrfs: fix a couple sleeps while holding a spinlock
Date: Fri, 8 Jul 2022 01:24:47 +0100 [thread overview]
Message-ID: <Ysd5TzHhzK2vwF0K@casper.infradead.org> (raw)
In-Reply-To: <20220707163144.GG15169@twin.jikos.cz>
On Thu, Jul 07, 2022 at 06:31:44PM +0200, David Sterba wrote:
> Adding Matthew to CC
>
> On Wed, Jul 06, 2022 at 10:09:44AM +0100, fdmanana@kernel.org wrote:
> > From: Filipe Manana <fdmanana@suse.com>
> >
> > After the recent conversions of a couple radix trees to XArrays, we now
> > can end up attempting to sleep while holding a spinlock.
>
> Ouch, I worked on the asumption that the old preload API is
> transparently provided by xarray and that sleeping under spinlock won't
> happen, otherwise the conversion from radix to xarray is not just an API
> rename. Note that for some time the radix_tree structure was just an
> alias for xarray, so this is not a new behaviour.
Umm ... the *structure* is identical, but the *API* is not. Or the
conversion would have happened long ago. There is no preload API
for the XArray because it's one of the worst features of the radix
tree API.
next prev parent reply other threads:[~2022-07-08 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 9:09 [PATCH 0/3] btrfs: fix a couple sleeps while holding a spinlock fdmanana
2022-07-06 9:09 ` [PATCH 1/3] btrfs: fix sleep while under a spinlock when allocating delayed inode fdmanana
2022-07-06 9:09 ` [PATCH 2/3] btrfs: fix sleep while under a spinlock when inserting a fs root fdmanana
2022-07-06 9:09 ` [PATCH 3/3] btrfs: free qgroup metadata without holding the fs roots lock fdmanana
2022-07-07 16:31 ` [PATCH 0/3] btrfs: fix a couple sleeps while holding a spinlock David Sterba
2022-07-08 0:24 ` Matthew Wilcox [this message]
2022-07-12 11:45 ` Nikolay Borisov
2022-07-13 13:59 ` Filipe Manana
2022-07-15 12:01 ` David Sterba
2022-07-15 12:47 ` Nikolay Borisov
2022-07-15 16:52 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ysd5TzHhzK2vwF0K@casper.infradead.org \
--to=willy@infradead.org \
--cc=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).