From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH v4 03/18] btrfs: introduce the skeleton of btrfs_subpage structure
Date: Sun, 24 Jan 2021 08:24:44 +0800 [thread overview]
Message-ID: <a3224353-fe6a-73df-ace5-5348baa0463f@gmx.com> (raw)
In-Reply-To: <20210123193744.GB1993@twin.jikos.cz>
On 2021/1/24 上午3:37, David Sterba wrote:
> On Wed, Jan 20, 2021 at 08:19:14AM +0800, Qu Wenruo wrote:
>>
>>
>> On 2021/1/20 上午12:06, David Sterba wrote:
>>> On Tue, Jan 19, 2021 at 04:51:45PM +0100, David Sterba wrote:
>>>> On Tue, Jan 19, 2021 at 06:54:28AM +0800, Qu Wenruo wrote:
>>>>> On 2021/1/19 上午6:46, David Sterba wrote:
>>>>>> On Sat, Jan 16, 2021 at 03:15:18PM +0800, Qu Wenruo wrote:
>>>>>>> + return;
>>>>>>> +
>>>>>>> + subpage = (struct btrfs_subpage *)detach_page_private(page);
>>>>>>> + ASSERT(subpage);
>>>>>>> + kfree(subpage);
>>>>>>> +}
>>>>>>> diff --git a/fs/btrfs/subpage.h b/fs/btrfs/subpage.h
>>>>>>> new file mode 100644
>>>>>>> index 000000000000..96f3b226913e
>>>>>>> --- /dev/null
>>>>>>> +++ b/fs/btrfs/subpage.h
>>>>>>> @@ -0,0 +1,31 @@
>>>>>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>>>>>> +
>>>>>>> +#ifndef BTRFS_SUBPAGE_H
>>>>>>> +#define BTRFS_SUBPAGE_H
>>>>>>> +
>>>>>>> +#include <linux/spinlock.h>
>>>>>>> +#include "ctree.h"
>>>>>>
>>>>>> So subpage.h would pull the whole ctree.h, that's not very nice. If
>>>>>> anything, the .c could include ctree.h because there are lots of the
>>>>>> common structure and function definitions, but not the .h. This creates
>>>>>> unnecessary include dependencies.
>>>>>>
>>>>>> Any pointer type you'd need in structures could be forward declared.
>>>>>
>>>>> Unfortunately, the main needed pointer is fs_info, and we're accessing
>>>>> it pretty frequently (mostly for sector/node size).
>>>>>
>>>>> I don't believe forward declaration would help in this case.
>>>>
>>>> I've looked at the final subpage.h and you add way too many static
>>>> inlines that don't seem to be necessary for the reasons the static
>>>> inlines are supposed to be used.
>>>
>>> The only file that includes subpage.h is extent_io.c, so as long as it
>>> stays like that it's manageable. But untangling the include hell still
>>> needs to hapen some day and new code that makes it harder worries me.
>>>
>> If going through the github branch, you will see there are more files
>> using subpage.h:
>> - extent_io.c
>> - disk-io.c
>> - file.c
>> - inode.c
>> - reflink.c
>> - relocation.c
>>
>> And furthermore, about the static inline abuse, the part really need
>> that static inline is the check against regular sector size, and
>> unfortunately, most outside callers need such check.
>>
>> I can put the pure subpage callers into subpage.c, but the generic
>> helpers handling both cases still need that.
>
> I had a look and this is too much. Just by counting 'static inline'
> (wher it's also part of the btrfs_page_clamp_* helpers) it's 30 and not
> all the functions are short enough for static inlines. Please make them
> all regular functions and put them to subpage.c and don't include
> ctree.h.
>
OK, I'll go that direction for next update.
Thanks,
Qu
next prev parent reply other threads:[~2021-01-24 0:26 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 7:15 [PATCH v4 00/18] btrfs: add read-only support for subpage sector size Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 01/18] btrfs: update locked page dirty/writeback/error bits in __process_pages_contig() Qu Wenruo
2021-01-19 21:41 ` Josef Bacik
2021-01-21 6:32 ` Qu Wenruo
2021-01-21 6:51 ` Qu Wenruo
2021-01-23 19:13 ` David Sterba
2021-01-24 0:35 ` Qu Wenruo
2021-01-24 11:49 ` David Sterba
2021-01-16 7:15 ` [PATCH v4 02/18] btrfs: merge PAGE_CLEAR_DIRTY and PAGE_SET_WRITEBACK into PAGE_START_WRITEBACK Qu Wenruo
2021-01-19 21:43 ` Josef Bacik
2021-01-19 21:45 ` Josef Bacik
2021-01-16 7:15 ` [PATCH v4 03/18] btrfs: introduce the skeleton of btrfs_subpage structure Qu Wenruo
2021-01-18 22:46 ` David Sterba
2021-01-18 22:54 ` Qu Wenruo
2021-01-19 15:51 ` David Sterba
2021-01-19 16:06 ` David Sterba
2021-01-20 0:19 ` Qu Wenruo
2021-01-23 19:37 ` David Sterba
2021-01-24 0:24 ` Qu Wenruo [this message]
2021-01-18 23:01 ` David Sterba
2021-01-16 7:15 ` [PATCH v4 04/18] btrfs: make attach_extent_buffer_page() to handle subpage case Qu Wenruo
2021-01-18 22:51 ` David Sterba
2021-01-19 21:54 ` Josef Bacik
2021-01-19 22:35 ` David Sterba
2021-01-26 7:29 ` Qu Wenruo
2021-01-27 19:58 ` David Sterba
2021-01-20 0:27 ` Qu Wenruo
2021-01-20 14:22 ` Josef Bacik
2021-01-21 1:20 ` Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 05/18] btrfs: make grab_extent_buffer_from_page() " Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 06/18] btrfs: support subpage for extent buffer page release Qu Wenruo
2021-01-20 14:44 ` Josef Bacik
2021-01-21 0:45 ` Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 07/18] btrfs: attach private to dummy extent buffer pages Qu Wenruo
2021-01-20 14:48 ` Josef Bacik
2021-01-21 0:47 ` Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 08/18] btrfs: introduce helper for subpage uptodate status Qu Wenruo
2021-01-19 19:45 ` David Sterba
2021-01-20 14:55 ` Josef Bacik
2021-01-26 7:21 ` Qu Wenruo
2021-01-20 15:00 ` Josef Bacik
2021-01-21 0:49 ` Qu Wenruo
2021-01-21 1:28 ` Josef Bacik
2021-01-21 1:38 ` Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 09/18] btrfs: introduce helper for subpage error status Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 10/18] btrfs: make set/clear_extent_buffer_uptodate() to support subpage size Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 11/18] btrfs: make btrfs_clone_extent_buffer() to be subpage compatible Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 12/18] btrfs: implement try_release_extent_buffer() for subpage metadata support Qu Wenruo
2021-01-20 15:05 ` Josef Bacik
2021-01-21 0:51 ` Qu Wenruo
2021-01-23 20:36 ` David Sterba
2021-01-25 20:02 ` Josef Bacik
2021-01-16 7:15 ` [PATCH v4 13/18] btrfs: introduce read_extent_buffer_subpage() Qu Wenruo
2021-01-20 15:08 ` Josef Bacik
2021-01-16 7:15 ` [PATCH v4 14/18] btrfs: extent_io: make endio_readpage_update_page_status() to handle subpage case Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 15/18] btrfs: disk-io: introduce subpage metadata validation check Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 16/18] btrfs: introduce btrfs_subpage for data inodes Qu Wenruo
2021-01-19 20:48 ` David Sterba
2021-01-20 15:28 ` Josef Bacik
2021-01-26 7:05 ` Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 17/18] btrfs: integrate page status update for data read path into begin/end_page_read() Qu Wenruo
2021-01-20 15:41 ` Josef Bacik
2021-01-21 1:05 ` Qu Wenruo
2021-01-16 7:15 ` [PATCH v4 18/18] btrfs: allow RO mount of 4K sector size fs on 64K page system Qu Wenruo
2021-01-18 23:17 ` [PATCH v4 00/18] btrfs: add read-only support for subpage sector size David Sterba
2021-01-18 23:26 ` Qu Wenruo
2021-01-24 12:29 ` David Sterba
2021-01-25 1:19 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3224353-fe6a-73df-ace5-5348baa0463f@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).