From: Goffredo Baroncelli <kreijack@libero.it>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org,
DanglingPointer <danglingpointerexception@gmail.com>,
Joshua Houghton <joshua.houghton@yandex.ru>,
David Sterba <dsterba@suse.com>
Subject: Re: [PATCH V2] btrfs-progs: add RAID5/6 support to btrfs fi us
Date: Thu, 28 May 2020 18:46:08 +0200 [thread overview]
Message-ID: <a705e6ad-cc99-b802-ec03-1ce56b04a95d@libero.it> (raw)
In-Reply-To: <20200528160721.GN18421@twin.jikos.cz>
On 5/28/20 6:07 PM, David Sterba wrote:
> On Wed, May 27, 2020 at 10:37:47PM +0200, Goffredo Baroncelli wrote:
>> this patch adds support for the raid5/6 profiles in the command
>> 'btrfs filesystem usage'.
>
>> $ sudo btrfs fi us /
>> Overall:
>> Device size: 40.00GiB
>> Device allocated: 8.28GiB
>> Device unallocated: 31.72GiB
>> Device missing: 0.00B
>> Used: 5.00GiB
>> Free (estimated): 17.36GiB (min: 17.36GiB)
>> Data ratio: 2.00
>> Metadata ratio: 0.00
>> Global reserve: 3.25MiB (used: 0.00B)
>>
>> Data,RAID6: Size:4.00GiB, Used:2.50GiB (62.53%)
>
>> Instead before:
>>
>> $ sudo btrfs fi us /
>> WARNING: RAID56 detected, not implemented
>> WARNING: RAID56 detected, not implemented
>> WARNING: RAID56 detected, not implemented
>> Overall:
>> Device size: 40.00GiB
>> Device allocated: 0.00B
>> Device unallocated: 40.00GiB
>> Device missing: 0.00B
>> Used: 0.00B
>> Free (estimated): 0.00B (min: 8.00EiB)
>> Data ratio: 0.00
>> Metadata ratio: 0.00
>> Global reserve: 3.25MiB (used: 0.00B)
>>
>> Data,RAID6: Size:4.00GiB, Used:2.50GiB (62.53%)
>
>> I rewrote the patch after some David's comments about the difficult to
>> review it because I changed too much code. So this time I tried to be less
>> intrusive. I leaved the old logic and I computed only the missing
>> values.
>
> Thanks, that's what I expected. Patch added to devel.
>
Greath ! Many thanks
BR
G.Baroncelli
--
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
prev parent reply other threads:[~2020-05-28 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 20:37 [PATCH V2] btrfs-progs: add RAID5/6 support to btrfs fi us Goffredo Baroncelli
2020-05-27 20:37 ` [PATCH] Add support for RAID5/6 to the command "btrfs fi us" Goffredo Baroncelli
2020-05-28 16:07 ` [PATCH V2] btrfs-progs: add RAID5/6 support to btrfs fi us David Sterba
2020-05-28 16:46 ` Goffredo Baroncelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a705e6ad-cc99-b802-ec03-1ce56b04a95d@libero.it \
--to=kreijack@libero.it \
--cc=danglingpointerexception@gmail.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=joshua.houghton@yandex.ru \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).