From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v2 06/12] btrfs-progs: add the ability to corrupt block group items
Date: Wed, 18 Aug 2021 17:33:18 -0400 [thread overview]
Message-ID: <a7d7bcfc46aa3ee37d509686cb2b43d7638df24f.1629322156.git.josef@toxicpanda.com> (raw)
In-Reply-To: <cover.1629322156.git.josef@toxicpanda.com>
While doing the extent tree v2 stuff I noticed that fsck doesn't detect
an invalid ->used value on the block group item in the normal mode. To
build a test case for this I need the ability to corrupt block group
items. This allows us to corrupt the various fields of a block group.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
btrfs-corrupt-block.c | 108 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 107 insertions(+), 1 deletion(-)
diff --git a/btrfs-corrupt-block.c b/btrfs-corrupt-block.c
index 77bdc810..80622f29 100644
--- a/btrfs-corrupt-block.c
+++ b/btrfs-corrupt-block.c
@@ -348,6 +348,24 @@ enum btrfs_key_field {
BTRFS_KEY_BAD,
};
+enum btrfs_block_group_field {
+ BTRFS_BLOCK_GROUP_ITEM_USED,
+ BTRFS_BLOCK_GROUP_ITEM_FLAGS,
+ BTRFS_BLOCK_GROUP_ITEM_CHUNK_OBJECTID,
+ BTRFS_BLOCK_GROUP_ITEM_BAD,
+};
+
+static enum btrfs_block_group_field convert_block_group_field(char *field)
+{
+ if (!strncmp(field, "used", FIELD_BUF_LEN))
+ return BTRFS_BLOCK_GROUP_ITEM_USED;
+ if (!strncmp(field, "flags", FIELD_BUF_LEN))
+ return BTRFS_BLOCK_GROUP_ITEM_FLAGS;
+ if (!strncmp(field, "chunk_objectid", FIELD_BUF_LEN))
+ return BTRFS_BLOCK_GROUP_ITEM_CHUNK_OBJECTID;
+ return BTRFS_BLOCK_GROUP_ITEM_BAD;
+}
+
static enum btrfs_inode_field convert_inode_field(char *field)
{
if (!strncmp(field, "isize", FIELD_BUF_LEN))
@@ -442,6 +460,83 @@ static u8 generate_u8(u8 orig)
return ret;
}
+static int corrupt_block_group(struct btrfs_root *root, u64 bg, char *field)
+{
+ struct btrfs_trans_handle *trans;
+ struct btrfs_path *path;
+ struct btrfs_block_group_item *bgi;
+ struct btrfs_key key;
+ enum btrfs_block_group_field corrupt_field;
+ u64 orig, bogus;
+ int ret = 0;
+
+ root = root->fs_info->extent_root;
+
+ corrupt_field = convert_block_group_field(field);
+ if (corrupt_field == BTRFS_BLOCK_GROUP_ITEM_BAD) {
+ fprintf(stderr, "Invalid field %s\n", field);
+ return -EINVAL;
+ }
+
+ path = btrfs_alloc_path();
+ if (!path)
+ return -ENOMEM;
+
+ trans = btrfs_start_transaction(root, 1);
+ if (IS_ERR(trans)) {
+ btrfs_free_path(path);
+ fprintf(stderr, "Couldn't start transaction %ld\n",
+ PTR_ERR(trans));
+ return PTR_ERR(trans);
+ }
+
+ key.objectid = bg;
+ key.type = BTRFS_BLOCK_GROUP_ITEM_KEY;
+ key.offset = 0;
+
+ ret = btrfs_search_slot(trans, root, &key, path, 0, 1);
+ if (ret < 0) {
+ fprintf(stderr, "Error searching for bg %llu %d\n", bg, ret);
+ goto out;
+ }
+
+ ret = 0;
+ btrfs_item_key_to_cpu(path->nodes[0], &key, path->slots[0]);
+ if (key.type != BTRFS_BLOCK_GROUP_ITEM_KEY) {
+ fprintf(stderr, "Couldn't find the bg %llu\n", bg);
+ goto out;
+ }
+
+ bgi = btrfs_item_ptr(path->nodes[0], path->slots[0],
+ struct btrfs_block_group_item);
+ switch (corrupt_field) {
+ case BTRFS_BLOCK_GROUP_ITEM_USED:
+ orig = btrfs_block_group_used(path->nodes[0], bgi);
+ bogus = generate_u64(orig);
+ btrfs_set_block_group_used(path->nodes[0], bgi, bogus);
+ break;
+ case BTRFS_BLOCK_GROUP_ITEM_CHUNK_OBJECTID:
+ orig = btrfs_block_group_chunk_objectid(path->nodes[0], bgi);
+ bogus = generate_u64(orig);
+ btrfs_set_block_group_chunk_objectid(path->nodes[0], bgi,
+ bogus);
+ break;
+ case BTRFS_BLOCK_GROUP_ITEM_FLAGS:
+ orig = btrfs_block_group_flags(path->nodes[0], bgi);
+ bogus = generate_u64(orig);
+ btrfs_set_block_group_flags(path->nodes[0], bgi, bogus);
+ break;
+ default:
+ ret = -EINVAL;
+ goto out;
+ }
+ btrfs_mark_buffer_dirty(path->nodes[0]);
+out:
+ btrfs_commit_transaction(trans, root);
+ btrfs_free_path(path);
+ return ret;
+}
+
static int corrupt_key(struct btrfs_root *root, struct btrfs_key *key,
char *field)
{
@@ -1150,6 +1245,7 @@ int main(int argc, char **argv)
u64 file_extent = (u64)-1;
u64 root_objectid = 0;
u64 csum_bytenr = 0;
+ u64 block_group = 0;
char field[FIELD_BUF_LEN];
field[0] = '\0';
@@ -1177,11 +1273,12 @@ int main(int argc, char **argv)
{ "delete", no_argument, NULL, 'd'},
{ "root", no_argument, NULL, 'r'},
{ "csum", required_argument, NULL, 'C'},
+ { "block-group", required_argument, NULL, 'B'},
{ "help", no_argument, NULL, GETOPT_VAL_HELP},
{ NULL, 0, NULL, 0 }
};
- c = getopt_long(argc, argv, "l:c:b:eEkuUi:f:x:m:K:I:D:d:r:C:",
+ c = getopt_long(argc, argv, "l:c:b:eEkuUi:f:x:m:K:I:D:d:r:C:B:",
long_options, NULL);
if (c < 0)
break;
@@ -1244,6 +1341,9 @@ int main(int argc, char **argv)
case 'C':
csum_bytenr = arg_strtou64(optarg);
break;
+ case 'B':
+ block_group = arg_strtou64(optarg);
+ break;
case GETOPT_VAL_HELP:
default:
print_usage(c != GETOPT_VAL_HELP);
@@ -1385,6 +1485,12 @@ int main(int argc, char **argv)
ret = corrupt_key(target_root, &key, field);
goto out_close;
}
+ if (block_group) {
+ if (*field == 0)
+ print_usage(1);
+ ret = corrupt_block_group(root, block_group, field);
+ goto out_close;
+ }
/*
* If we made it here and we have extent set then we didn't specify
* inode and we're screwed.
--
2.26.3
next prev parent reply other threads:[~2021-08-18 21:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 21:33 [PATCH v2 00/12] btrfs-progs: make check handle invalid bg items Josef Bacik
2021-08-18 21:33 ` [PATCH v2 01/12] btrfs-progs: fix running lowmem check tests Josef Bacik
2021-08-19 5:40 ` Qu Wenruo
2021-08-23 14:54 ` David Sterba
2021-08-18 21:33 ` [PATCH v2 02/12] btrfs-progs: do not infinite loop on corrupt keys with lowmem mode Josef Bacik
2021-08-19 5:42 ` Qu Wenruo
2021-08-23 15:04 ` David Sterba
2021-08-23 18:44 ` Josef Bacik
2021-08-23 23:34 ` Qu Wenruo
2021-08-18 21:33 ` [PATCH v2 03/12] btrfs-progs: propagate fs root errors in " Josef Bacik
2021-08-19 5:43 ` Qu Wenruo
2021-08-18 21:33 ` [PATCH v2 04/12] btrfs-progs: propagate extent item " Josef Bacik
2021-08-19 5:45 ` Qu Wenruo
2021-08-18 21:33 ` [PATCH v2 05/12] btrfs-progs: do not double add unaligned extent records Josef Bacik
2021-08-18 21:33 ` Josef Bacik [this message]
2021-08-18 21:33 ` [PATCH v2 07/12] btrfs-progs: add the ability to corrupt fields of the super block Josef Bacik
2021-08-23 14:59 ` David Sterba
2021-08-18 21:33 ` [PATCH v2 08/12] btrfs-progs: make check detect and fix invalid used for block groups Josef Bacik
2021-08-19 5:54 ` Qu Wenruo
2021-08-18 21:33 ` [PATCH v2 09/12] btrfs-progs: make check detect and fix problems with super_bytes_used Josef Bacik
2021-08-19 5:56 ` Qu Wenruo
2021-08-18 21:33 ` [PATCH v2 10/12] btrfs-progs: check btrfs_super_used in lowmem check Josef Bacik
2021-08-19 5:57 ` Qu Wenruo
2021-08-18 21:33 ` [PATCH v2 11/12] btrfs-progs: add a test image with a corrupt block group item Josef Bacik
2021-08-18 21:33 ` [PATCH v2 12/12] btrfs-progs: add a test image with an invalid super bytes_used Josef Bacik
2021-08-23 18:31 ` [PATCH v2 00/12] btrfs-progs: make check handle invalid bg items David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7d7bcfc46aa3ee37d509686cb2b43d7638df24f.1629322156.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).