From: Nikolay Borisov <nborisov@suse.com>
To: jeffm@suse.com, dsterba@suse.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 0/3] btrfs: qgroup rescan races (part 1)
Date: Thu, 3 May 2018 09:23:36 +0300 [thread overview]
Message-ID: <b12bde4d-babe-8d2f-1ae8-86e3e9fddbc3@suse.com> (raw)
In-Reply-To: <20180502211156.9460-1-jeffm@suse.com>
On 3.05.2018 00:11, jeffm@suse.com wrote:
> From: Jeff Mahoney <jeffm@suse.com>
>
> Hi Dave -
>
> Here's the updated patchset for the rescan races. This fixes the issue
> where we'd try to start multiple workers. It introduces a new "ready"
> bool that we set during initialization and clear while queuing the worker.
> The queuer is also now responsible for most of the initialization.
>
> I have a separate patch set start that gets rid of the racy mess surrounding
> the rescan worker startup. We can handle it in btrfs_run_qgroups and
> just set a flag to start it everywhere else.
I'd be interested in seeing those patches. Some time ago I did send a
patch which cleaned up the way qgroup rescan was initiated. It was done
from "btrfs_run_qgroups" and I think this is messy. Whatever we do we
ought to really have well-defined semantics when qgroups rescan are run,
preferably we shouldn't be conflating rescan + run (unless there is
_really_ good reason to do). In the past the rescan from scan was used
only during qgroup enabling.
>
> -Jeff
>
> ---
>
> Jeff Mahoney (3):
> btrfs: qgroups, fix rescan worker running races
> btrfs: qgroups, remove unnecessary memset before btrfs_init_work
> btrfs: qgroup, don't try to insert status item after ENOMEM in rescan
> worker
>
> fs/btrfs/async-thread.c | 1 +
> fs/btrfs/ctree.h | 2 +
> fs/btrfs/qgroup.c | 100 +++++++++++++++++++++++++++---------------------
> 3 files changed, 60 insertions(+), 43 deletions(-)
>
next prev parent reply other threads:[~2018-05-03 6:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 21:11 [PATCH v3 0/3] btrfs: qgroup rescan races (part 1) jeffm
2018-05-02 21:11 ` [PATCH 1/3] btrfs: qgroups, fix rescan worker running races jeffm
2018-05-03 7:24 ` Nikolay Borisov
2018-05-03 13:39 ` Jeff Mahoney
2018-05-03 15:52 ` Nikolay Borisov
2018-05-03 15:57 ` Jeff Mahoney
2018-05-10 19:49 ` Jeff Mahoney
2018-05-10 23:04 ` Jeff Mahoney
2020-01-16 6:41 ` Qu Wenruo
2018-05-02 21:11 ` [PATCH 2/3] btrfs: qgroups, remove unnecessary memset before btrfs_init_work jeffm
2018-05-02 21:11 ` [PATCH 3/3] btrfs: qgroup, don't try to insert status item after ENOMEM in rescan worker jeffm
2018-05-03 6:23 ` Nikolay Borisov [this message]
2018-05-03 22:27 ` [PATCH v3 0/3] btrfs: qgroup rescan races (part 1) Jeff Mahoney
2018-05-04 5:59 ` Nikolay Borisov
2018-05-04 13:32 ` Jeff Mahoney
2018-05-04 13:41 ` Nikolay Borisov
2019-11-28 3:28 ` Qu Wenruo
2019-12-03 19:32 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b12bde4d-babe-8d2f-1ae8-86e3e9fddbc3@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.com \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).