From: Qu Wenruo <wqu@suse.com>
To: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/3] btrfs: backref: Implement btrfs_backref_iterator_next()
Date: Fri, 14 Feb 2020 15:25:45 +0800 [thread overview]
Message-ID: <b1fefe8e-644b-0b25-1a70-79c98024de9f@suse.com> (raw)
In-Reply-To: <20200214063302.47388-3-wqu@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 2487 bytes --]
On 2020/2/14 下午2:33, Qu Wenruo wrote:
> This function will go next inline/keyed backref for
> btrfs_backref_iterator infrastructure.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> fs/btrfs/backref.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index 73c4829609c9..0f231cd69675 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -2310,3 +2310,51 @@ int btrfs_backref_iterator_start(struct btrfs_backref_iterator *iterator,
> btrfs_release_path(path);
> return ret;
> }
> +
> +int btrfs_backref_iterator_next(struct btrfs_backref_iterator *iterator)
> +{
> + struct extent_buffer *eb = btrfs_backref_get_eb(iterator);
> + struct btrfs_path *path = iterator->path;
> + struct btrfs_extent_inline_ref *iref;
> + int ret;
> + u32 size;
> +
> + if (iterator->cur_key.type == BTRFS_EXTENT_ITEM_KEY ||
> + iterator->cur_key.type == BTRFS_METADATA_ITEM_KEY) {
> + /* We're still inside the inline refs */
> + if (btrfs_backref_has_tree_block_info(iterator)) {
> + /* First tree block info */
> + size = sizeof(struct btrfs_tree_block_info);
> + } else {
> + /* Use inline ref type to determine the size */
> + int type;
> +
> + iref = (struct btrfs_extent_inline_ref *)
> + (iterator->cur_ptr);
> + type = btrfs_extent_inline_ref_offset(eb, iref);
Oh, I'm blindly complete the function name without checking the last word.
> +
> + size = btrfs_extent_inline_ref_size(type);
> + }
> + iterator->cur_ptr += size;
> + if (iterator->cur_ptr < iterator->end_ptr)
> + return 0;
> +
> + /* All inline items iterated, fall through */
> + }
> + /* We're at keyed items, there is no inline item, just go next item */
> + ret = btrfs_next_item(iterator->fs_info->extent_root, iterator->path);
> + if (ret > 0 || ret < 0)
> + return ret;
> +
> + btrfs_item_key_to_cpu(path->nodes[0], &iterator->cur_key,
> + path->slots[0]);
> + if (iterator->cur_key.objectid != iterator->bytenr ||
> + (iterator->cur_key.type != BTRFS_TREE_BLOCK_REF_KEY &&
> + iterator->cur_key.type != BTRFS_SHARED_BLOCK_REF_KEY))
> + return 1;
> + iterator->item_ptr = btrfs_item_ptr_offset(path->nodes[0],
> + path->slots[0]);
> + iterator->cur_ptr = iterator->item_ptr;
> + iterator->end_ptr = btrfs_item_end_nr(path->nodes[0], path->slots[0]);
> + return 0;
> +}
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-14 7:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 6:32 [PATCH 0/3] Btrfs: relocation: Refactor build_backref_tree() using btrfs_backref_iterator infrastructure Qu Wenruo
2020-02-14 6:33 ` [PATCH 1/3] btrfs: backref: Introduce the skeleton of btrfs_backref_iterator Qu Wenruo
2020-02-14 6:33 ` [PATCH 2/3] btrfs: backref: Implement btrfs_backref_iterator_next() Qu Wenruo
2020-02-14 7:25 ` Qu Wenruo [this message]
2020-02-14 6:33 ` [PATCH 3/3] btrfs: relocation: Use btrfs_backref_iterator infrastructure Qu Wenruo
2020-02-14 6:56 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1fefe8e-644b-0b25-1a70-79c98024de9f@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).