From: Josef Bacik <josef@toxicpanda.com>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>,
Chris Mason <clm@fb.com>, Nikolay Borisov <nborisov@suse.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Hannes Reinecke <hare@suse.com>,
Anand Jain <anand.jain@oracle.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v6 24/28] btrfs: enable relocation in HMZONED mode
Date: Wed, 18 Dec 2019 10:01:29 -0500 [thread overview]
Message-ID: <b538ea95-9493-88b7-de6e-fa94dca43665@toxicpanda.com> (raw)
In-Reply-To: <20191218104920.ozsa3pawkvxs2gg5@naota.dhcp.fujisawa.hgst.com>
On 12/18/19 5:49 AM, Naohiro Aota wrote:
> On Tue, Dec 17, 2019 at 04:32:04PM -0500, Josef Bacik wrote:
>> On 12/12/19 11:09 PM, Naohiro Aota wrote:
>>> To serialize allocation and submit_bio, we introduced mutex around them. As
>>> a result, preallocation must be completely disabled to avoid a deadlock.
>>>
>>> Since current relocation process relies on preallocation to move file data
>>> extents, it must be handled in another way. In HMZONED mode, we just
>>> truncate the inode to the size that we wanted to pre-allocate. Then, we
>>> flush dirty pages on the file before finishing relocation process.
>>> run_delalloc_hmzoned() will handle all the allocation and submit IOs to
>>> the underlying layers.
>>>
>>> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
>>> ---
>>> fs/btrfs/relocation.c | 39 +++++++++++++++++++++++++++++++++++++--
>>> 1 file changed, 37 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
>>> index d897a8e5e430..2d17b7566df4 100644
>>> --- a/fs/btrfs/relocation.c
>>> +++ b/fs/btrfs/relocation.c
>>> @@ -3159,6 +3159,34 @@ int prealloc_file_extent_cluster(struct inode *inode,
>>> if (ret)
>>> goto out;
>>> + /*
>>> + * In HMZONED, we cannot preallocate the file region. Instead,
>>> + * we dirty and fiemap_write the region.
>>> + */
>>> +
>>> + if (btrfs_fs_incompat(btrfs_sb(inode->i_sb), HMZONED)) {
>>> + struct btrfs_root *root = BTRFS_I(inode)->root;
>>> + struct btrfs_trans_handle *trans;
>>> +
>>> + end = cluster->end - offset + 1;
>>> + trans = btrfs_start_transaction(root, 1);
>>> + if (IS_ERR(trans))
>>> + return PTR_ERR(trans);
>>> +
>>> + inode->i_ctime = current_time(inode);
>>> + i_size_write(inode, end);
>>> + btrfs_ordered_update_i_size(inode, end, NULL);
>>> + ret = btrfs_update_inode(trans, root, inode);
>>> + if (ret) {
>>> + btrfs_abort_transaction(trans, ret);
>>> + btrfs_end_transaction(trans);
>>> + return ret;
>>> + }
>>> + ret = btrfs_end_transaction(trans);
>>> +
>>> + goto out;
>>> + }
>>> +
>>
>> Why are we arbitrarily extending the i_size here? If we don't need prealloc
>> we don't need to jack up the i_size either.
>
> We need to extend i_size to read data from the relocating block
> group. If not, btrfs_readpage() in relocate_file_extent_cluster()
> always reads zero filled page because the read position is beyond the
> file size.
Right but the finish_ordered_io stuff will do the btrfs_ordered_update_i_size()
once the IO is complete. So all you really need is the i_size_write and the
btrfs_update_inode. If this crashes you'll have an inode that has a i_size with
no extents up to i_size. This is fine for NO_HOLES but not fine for !NO_HOLES.
Thanks,
Josef
next prev parent reply other threads:[~2019-12-18 15:01 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 4:08 [PATCH v6 00/28] btrfs: zoned block device support Naohiro Aota
2019-12-13 4:08 ` [PATCH v6 01/28] btrfs: introduce HMZONED feature flag Naohiro Aota
2019-12-13 4:08 ` [PATCH v6 02/28] btrfs: Get zone information of zoned block devices Naohiro Aota
2019-12-13 16:18 ` Josef Bacik
2019-12-18 2:29 ` Naohiro Aota
2019-12-13 4:08 ` [PATCH v6 03/28] btrfs: Check and enable HMZONED mode Naohiro Aota
2019-12-13 16:21 ` Josef Bacik
2019-12-18 4:17 ` Naohiro Aota
2019-12-13 4:08 ` [PATCH v6 04/28] btrfs: disallow RAID5/6 in " Naohiro Aota
2019-12-13 16:21 ` Josef Bacik
2019-12-13 4:08 ` [PATCH v6 05/28] btrfs: disallow space_cache " Naohiro Aota
2019-12-13 16:24 ` Josef Bacik
2019-12-18 4:28 ` Naohiro Aota
2019-12-13 4:08 ` [PATCH v6 06/28] btrfs: disallow NODATACOW " Naohiro Aota
2019-12-13 16:25 ` Josef Bacik
2019-12-13 4:08 ` [PATCH v6 07/28] btrfs: disable fallocate " Naohiro Aota
2019-12-13 16:26 ` Josef Bacik
2019-12-13 4:08 ` [PATCH v6 08/28] btrfs: implement log-structured superblock for " Naohiro Aota
2019-12-13 16:38 ` Josef Bacik
2019-12-13 21:58 ` Damien Le Moal
2019-12-17 19:17 ` Josef Bacik
2019-12-13 4:08 ` [PATCH v6 09/28] btrfs: align device extent allocation to zone boundary Naohiro Aota
2019-12-13 16:52 ` Josef Bacik
2019-12-13 4:08 ` [PATCH v6 10/28] btrfs: do sequential extent allocation in HMZONED mode Naohiro Aota
2019-12-17 19:19 ` Josef Bacik
2019-12-13 4:08 ` [PATCH v6 11/28] btrfs: make unmirroed BGs readonly only if we have at least one writable BG Naohiro Aota
2019-12-17 19:25 ` Josef Bacik
2019-12-18 7:35 ` Naohiro Aota
2019-12-18 14:54 ` Josef Bacik
2019-12-13 4:08 ` [PATCH v6 12/28] btrfs: ensure metadata space available on/after degraded mount in HMZONED Naohiro Aota
2019-12-17 19:32 ` Josef Bacik
2019-12-13 4:09 ` [PATCH v6 13/28] btrfs: reset zones of unused block groups Naohiro Aota
2019-12-17 19:33 ` Josef Bacik
2019-12-13 4:09 ` [PATCH v6 14/28] btrfs: redirty released extent buffers in HMZONED mode Naohiro Aota
2019-12-17 19:41 ` Josef Bacik
2019-12-13 4:09 ` [PATCH v6 15/28] btrfs: serialize data allocation and submit IOs Naohiro Aota
2019-12-17 19:49 ` Josef Bacik
2019-12-19 6:54 ` Naohiro Aota
2019-12-19 14:01 ` Josef Bacik
2020-01-21 6:54 ` Naohiro Aota
2019-12-13 4:09 ` [PATCH v6 16/28] btrfs: implement atomic compressed IO submission Naohiro Aota
2019-12-13 4:09 ` [PATCH v6 17/28] btrfs: support direct write IO in HMZONED Naohiro Aota
2019-12-13 4:09 ` [PATCH v6 18/28] btrfs: serialize meta IOs on HMZONED mode Naohiro Aota
2019-12-13 4:09 ` [PATCH v6 19/28] btrfs: wait existing extents before truncating Naohiro Aota
2019-12-17 19:53 ` Josef Bacik
2019-12-13 4:09 ` [PATCH v6 20/28] btrfs: avoid async checksum on HMZONED mode Naohiro Aota
2019-12-13 4:09 ` [PATCH v6 21/28] btrfs: disallow mixed-bg in " Naohiro Aota
2019-12-17 19:56 ` Josef Bacik
2019-12-18 8:03 ` Naohiro Aota
2019-12-13 4:09 ` [PATCH v6 22/28] btrfs: disallow inode_cache " Naohiro Aota
2019-12-17 19:56 ` Josef Bacik
2019-12-13 4:09 ` [PATCH v6 23/28] btrfs: support dev-replace " Naohiro Aota
2019-12-17 21:05 ` Josef Bacik
2019-12-18 6:00 ` Naohiro Aota
2019-12-18 14:58 ` Josef Bacik
2019-12-13 4:09 ` [PATCH v6 24/28] btrfs: enable relocation " Naohiro Aota
2019-12-17 21:32 ` Josef Bacik
2019-12-18 10:49 ` Naohiro Aota
2019-12-18 15:01 ` Josef Bacik [this message]
2019-12-13 4:09 ` [PATCH v6 25/28] btrfs: relocate block group to repair IO failure in HMZONED Naohiro Aota
2019-12-17 22:04 ` Josef Bacik
2019-12-13 4:09 ` [PATCH v6 26/28] btrfs: split alloc_log_tree() Naohiro Aota
2019-12-13 4:09 ` [PATCH v6 27/28] btrfs: enable tree-log on HMZONED mode Naohiro Aota
2019-12-17 22:08 ` Josef Bacik
2019-12-18 9:35 ` Naohiro Aota
2019-12-13 4:09 ` [PATCH v6 28/28] btrfs: enable to mount HMZONED incompat flag Naohiro Aota
2019-12-17 22:09 ` Josef Bacik
2019-12-13 4:15 ` [PATCH RFC v2] libblkid: implement zone-aware probing for HMZONED btrfs Naohiro Aota
2019-12-19 20:19 ` [PATCH v6 00/28] btrfs: zoned block device support David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b538ea95-9493-88b7-de6e-fa94dca43665@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=damien.lemoal@wdc.com \
--cc=dsterba@suse.com \
--cc=hare@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).