Re: [PATCH v2 02/11] btrfs: export the expected file extent through can_nocow_extent()

From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Filipe Manana <fdmanana@kernel.org>, Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH v2 02/11] btrfs: export the expected file extent through can_nocow_extent()
Date: Fri, 10 May 2024 07:25:07 +0930	[thread overview]
Message-ID: <b8538fb0-e6bc-4dfd-addc-756048bbcad3@gmx.com> (raw)
In-Reply-To: <CAL3q7H4ruNd9xUvp7yY-CPEQAvM+6Kd+N2Nd6SDgXUpj=OhQAg@mail.gmail.com>

在 2024/5/10 01:52, Filipe Manana 写道:
[...]
>> + */
>> +struct btrfs_file_extent {
>> +       u64 disk_bytenr;
>> +       u64 disk_num_bytes;
>> +
>> +       u64 num_bytes;
>> +       u64 ram_bytes;
>> +       u64 offset;
>> +
>> +       u8 compression;
>
> The blank lines between the members seem kind of ad-hoc, redundant to
> me - i.e. no logical grouping.
> Maybe I missed something?

This is to separate the members so that, the disk_* ones are only
referring to a data extent uniquely.

The ram_bytes/num_bytes/offset are the ones to specify the referred
range inside the uncompressed extent.
Finally a u8 because it's not u64.

But for sure, I can remove all the new lines, because the grouping is
not that strong.

Thanks,
Qu