Linux-BTRFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Remove unnecessary condition check
@ 2019-08-12 17:38 Diego Calleja
  2019-08-12 18:13 ` Nikolay Borisov
  0 siblings, 1 reply; 2+ messages in thread
From: Diego Calleja @ 2019-08-12 17:38 UTC (permalink / raw)
  To: linux-btrfs

extent_io.c:__extent_writepage_io has this code:

if (!compressed)
	...
else if (compressed)


Signed-off-by: Diego Calleja <diegocg@gmail.com>
---
 fs/btrfs/extent_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 1ff438fd5bc2..a53fb7b8a262 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -3498,7 +3498,7 @@ static noinline_for_stack int __extent_writepage_io(struct inode *inode,
 				btrfs_writepage_endio_finish_ordered(page, cur,
 							    cur + iosize - 1,
 							    1);
-			else if (compressed) {
+			else {
 				/* we don't want to end_page_writeback on
 				 * a compressed extent.  this happens
 				 * elsewhere
-- 
2.22.0





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove unnecessary condition check
  2019-08-12 17:38 [PATCH] Remove unnecessary condition check Diego Calleja
@ 2019-08-12 18:13 ` Nikolay Borisov
  0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Borisov @ 2019-08-12 18:13 UTC (permalink / raw)
  To: Diego Calleja, linux-btrfs



On 12.08.19 г. 20:38 ч., Diego Calleja wrote:
> extent_io.c:__extent_writepage_io has this code:
> 
> if (!compressed)
> 	...
> else if (compressed)
> 
> 
> Signed-off-by: Diego Calleja <diegocg@gmail.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  fs/btrfs/extent_io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 1ff438fd5bc2..a53fb7b8a262 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -3498,7 +3498,7 @@ static noinline_for_stack int __extent_writepage_io(struct inode *inode,
>  				btrfs_writepage_endio_finish_ordered(page, cur,
>  							    cur + iosize - 1,
>  							    1);
> -			else if (compressed) {
> +			else {
>  				/* we don't want to end_page_writeback on
>  				 * a compressed extent.  this happens
>  				 * elsewhere
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12 17:38 [PATCH] Remove unnecessary condition check Diego Calleja
2019-08-12 18:13 ` Nikolay Borisov

Linux-BTRFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \
		linux-btrfs@vger.kernel.org linux-btrfs@archiver.kernel.org
	public-inbox-index linux-btrfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox