From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:39352 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728474AbeIXRzJ (ORCPT ); Mon, 24 Sep 2018 13:55:09 -0400 Subject: Re: [PATCH 1/9] fstests: btrfs: _scratch_mkfs_sized fix min size without mixed option To: Qu Wenruo Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org References: <1537784193-24431-1-git-send-email-anand.jain@oracle.com> <1537784193-24431-2-git-send-email-anand.jain@oracle.com> From: Anand Jain Message-ID: Date: Mon, 24 Sep 2018 19:53:13 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 09/24/2018 06:58 PM, Qu Wenruo wrote: > > > On 2018/9/24 下午6:16, Anand Jain wrote: >> As of now _scratch_mkfs_sized check if the requested size is below 1G >> and forces the --mixed option for the mkfs.btrfs. Well the correct size >> at which we need to force the mixed option is 114294784bytes. Fix that. > > How this size is get from? > If it's from btrfs_min_dev_size(), I strongly recommend to add reference > here, and don't use the ugly intermediate number. > > > BTW, this number is related to mkfs profile. > If you really want to use some maximum number, please follow the max > possible value in btrfs_min_dev_size(), which should be 229M other than > 106M. Thanks for the comments. I completely missed out the point of other group profile requiring more than ~115 bytes. Will fix. Yep the ref for the size is btrfs_min_dev_size(). -Anand > Thanks, > Qu > >> >> Signed-off-by: Anand Jain >> --- >> common/rc | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/common/rc b/common/rc >> index d5bb1feee2c3..bcdbf03e1bf0 100644 >> --- a/common/rc >> +++ b/common/rc >> @@ -969,7 +969,9 @@ _scratch_mkfs_sized() >> ;; >> btrfs) >> local mixed_opt= >> - (( fssize <= 1024 * 1024 * 1024 )) && mixed_opt='--mixed' >> + # minimum size that's needed without the mixed option. >> + # Non mixed mode is also the default option. >> + (( fssize < 114294784 )) && mixed_opt='--mixed' >> $MKFS_BTRFS_PROG $MKFS_OPTIONS $mixed_opt -b $fssize $SCRATCH_DEV >> ;; >> jfs) >> >