From: Anand Jain <anand.jain@oracle.com>
To: David Sterba <dsterba@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/2] provide fsid in sysfs devinfo
Date: Tue, 9 Nov 2021 18:09:15 +0800 [thread overview]
Message-ID: <be907432-4279-7226-b79e-192d633cf3ac@oracle.com> (raw)
In-Reply-To: <cover.1634829757.git.anand.jain@oracle.com>
David,
And this one could also merge?
Thanks, Anand
On 21/10/21 11:31 pm, Anand Jain wrote:
> v2:
> Fix sysfs_emit conversion at the two non-sysfs show functions in patch1.
>
> btrfs-progs tries to read the fsid from the super-block for a missing
> device and, it fails. It needs to find out if the device is a seed
> device. It does it by comparing the device's fsid with the fsid of the
> mounted filesystem. To help this scenario introduce a new sysfs file to
> read the fsid from the kernel.
> /sys/fs/btrfs/<fsid>/devinfo/<devid>/fsid
>
> Patch 1 is a cleanup converts scnprtin()f and snprintf() to sysfs_emit()
> Patch 2 introduces the new sysfs interface as above
>
> The other implementation choice is to add another parameter to the
> struct btrfs_ioctl_dev_info_args and use BTRFS_IOC_DEV_INFO ioctl. But
> then backward kernel compatibility with the newer btrfs-progs is more
> complicated. If needed, we can add that too.
>
> Related btrfs-progs patches:
> btrfs-progs: prepare helper device_is_seed
> btrfs-progs: read fsid from the sysfs in device_is_seed
>
> Anand Jain (2):
> btrfs: sysfs convert scnprintf and snprintf to use sysfs_emit
> btrfs: sysfs add devinfo/fsid to retrieve fsid from the device
>
> fs/btrfs/sysfs.c | 106 +++++++++++++++++++++++++----------------------
> 1 file changed, 57 insertions(+), 49 deletions(-)
>
prev parent reply other threads:[~2021-11-09 10:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 15:31 [PATCH v2 0/2] provide fsid in sysfs devinfo Anand Jain
2021-10-21 15:31 ` [PATCH v2 1/2] btrfs: sysfs convert scnprintf and snprintf to use sysfs_emit Anand Jain
2021-10-21 16:19 ` David Sterba
2021-10-21 16:25 ` David Sterba
2021-10-21 16:27 ` Anand Jain
2021-10-21 16:27 ` Anand Jain
2021-10-21 15:31 ` [PATCH v2 2/2] btrfs: sysfs add devinfo/fsid to retrieve fsid from the device Anand Jain
2021-11-16 17:16 ` David Sterba
2021-11-17 3:29 ` Anand Jain
2021-12-01 16:56 ` Anand Jain
2021-12-07 18:56 ` David Sterba
2021-12-07 18:56 ` David Sterba
2021-11-09 10:09 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be907432-4279-7226-b79e-192d633cf3ac@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).