linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 3/3] btrfs: remove the again: tag in process_one_batch()
Date: Mon, 24 Aug 2020 13:02:50 -0400	[thread overview]
Message-ID: <bffc98ac-b42c-9598-96b4-7a54a54668b4@toxicpanda.com> (raw)
In-Reply-To: <20200824075959.85212-4-wqu@suse.com>

On 8/24/20 3:59 AM, Qu Wenruo wrote:
> The again: tag here is for us to retry when we failed to lock extent
> range, which is only used once.
> 
> Instead of the open tag, integrate prepare_pages() and
> lock_and_cleanup_extent_if_need() into lock_pages_and_extent(), and do
> the retry inside the function.
> 
> Signed-off-by: Qu Wenruo <wqu@suse.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

  reply	other threads:[~2020-08-24 17:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24  7:59 [PATCH v2 0/3] btrfs: basic refactor of btrfs_buffered_write() Qu Wenruo
2020-08-24  7:59 ` [PATCH v2 1/3] btrfs: change how we calculate the nrptrs for btrfs_buffered_write() Qu Wenruo
2020-08-24 10:32   ` Nikolay Borisov
2020-08-24 16:59   ` Josef Bacik
2020-08-24  7:59 ` [PATCH v2 2/3] btrfs: refactor btrfs_buffered_write() into process_one_batch() Qu Wenruo
2020-08-24 17:01   ` Josef Bacik
2020-08-24  7:59 ` [PATCH v2 3/3] btrfs: remove the again: tag in process_one_batch() Qu Wenruo
2020-08-24 17:02   ` Josef Bacik [this message]
2020-08-26 11:20   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bffc98ac-b42c-9598-96b4-7a54a54668b4@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).