From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30229C43334 for ; Thu, 7 Jul 2022 13:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235357AbiGGNJD (ORCPT ); Thu, 7 Jul 2022 09:09:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235404AbiGGNJA (ORCPT ); Thu, 7 Jul 2022 09:09:00 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DA5F237E1 for ; Thu, 7 Jul 2022 06:08:56 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A9226220E9; Thu, 7 Jul 2022 13:08:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657199335; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0S8MWStob+uQiHAVtnnF//fZLRH2Qf/MDYlzGYL0yvE=; b=HLZ0AfDW3jO64UVjpuW/jQxSOiaI1Vtvr6d1RRhw88xIn21e2dyDOr9RScbGiiwTcZHlHf 5hVh0poEbLFcMp/8K3vxIdtbvG3iDZhmewmIe+QJdtJjSXOIvbhoU1XkYPVe8btE5iskWx vrKzn5LehmzGU6oXJQykJcb+TIwpNeM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5EE7313461; Thu, 7 Jul 2022 13:08:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hNprFOfaxmLNBwAAMHmgww (envelope-from ); Thu, 07 Jul 2022 13:08:55 +0000 Message-ID: Date: Thu, 7 Jul 2022 16:08:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 6/6] btrfs: don't call btrfs_page_set_checked in finish_compressed_bio_read Content-Language: en-US To: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba Cc: linux-btrfs@vger.kernel.org References: <20220707053331.211259-1-hch@lst.de> <20220707053331.211259-7-hch@lst.de> From: Nikolay Borisov In-Reply-To: <20220707053331.211259-7-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 7.07.22 г. 8:33 ч., Christoph Hellwig wrote: > This flag was used to communicate that the low-level compression code > already did verify the checksum to the high-level I/O completion code. > > But it has been unused for a long time as the upper btrfs_bio for the > decompressed data had a NULL csum pointer basically since that pointer > existed and the code already checks for that a little later. > > Note that this does not affect the other use of the checked flag, which > is only used for the COW fixup worker. > > Signed-off-by: Christoph Hellwig Reviewed-by: Nikolay Borisov