Linux-BTRFS Archive on lore.kernel.org
 help / color / Atom feed
From: Goffredo Baroncelli <kreijack@libero.it>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, linux-btrfs@vger.kernel.org
Cc: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>,
	Goffredo Baroncelli <kreijack@inwind.it>
Subject: Re: [PATCH 1/4] btrfs-progs: Add missing fields to btrfs_raid_array[] for raid1c[34].
Date: Thu, 26 Mar 2020 18:28:05 +0100
Message-ID: <caf00fb2-cbf6-e9d4-7f5d-66a81d87b57d@libero.it> (raw)
In-Reply-To: <484bec80-2469-b638-b80b-8811a0e8e9ff@gmx.com>

On 3/26/20 2:59 AM, Qu Wenruo wrote:
> 
> 
> On 2020/3/26 上午4:10, Goffredo Baroncelli wrote:
>> From: Goffredo Baroncelli <kreijack@inwind.it>
>>
>> Signed-off-by: Goffredo Baroncelli <kreijack@inwind.it>
>> ---
>>   volumes.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/volumes.c b/volumes.c
>> index b46bf598..9e37f986 100644
>> --- a/volumes.c
>> +++ b/volumes.c
>> @@ -65,6 +65,8 @@ const struct btrfs_raid_attr btrfs_raid_array[BTRFS_NR_RAID_TYPES] = {
>>   		.tolerated_failures = 2,
>>   		.devs_increment	= 3,
>>   		.ncopies	= 3,
>> +		.raid_name	= "raid1c3",
>> +		.bg_flag	= BTRFS_BLOCK_GROUP_RAID1C3,
> 
> Since you're here, mind to also add .mindev_error?

I will take care of
BR
G.Baroncelli

> 
> Thanks,
> Qu
>>   	},
>>   	[BTRFS_RAID_RAID1C4] = {
>>   		.sub_stripes	= 1,
>> @@ -74,6 +76,8 @@ const struct btrfs_raid_attr btrfs_raid_array[BTRFS_NR_RAID_TYPES] = {
>>   		.tolerated_failures = 3,
>>   		.devs_increment	= 4,
>>   		.ncopies	= 4,
>> +		.raid_name	= "raid1c4",
>> +		.bg_flag	= BTRFS_BLOCK_GROUP_RAID1C4,
>>   	},
>>   	[BTRFS_RAID_DUP] = {
>>   		.sub_stripes	= 1,
>>


-- 
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 20:10 [RFC][PATCH] btrfs-progs: add warning for mixed prfofiles filesystem Goffredo Baroncelli
2020-03-25 20:10 ` [PATCH 1/4] btrfs-progs: Add missing fields to btrfs_raid_array[] for raid1c[34] Goffredo Baroncelli
2020-03-26  1:59   ` Qu Wenruo
2020-03-26 17:28     ` Goffredo Baroncelli [this message]
2020-03-25 20:10 ` [PATCH 2/4] btrfs-progs: Add BTRFS_EXTENDED_PROFILE_MASK mask Goffredo Baroncelli
2020-03-25 20:10 ` [PATCH 3/4] btrfs-progs: Add btrfs_check_for_mixed_profiles_by_* function Goffredo Baroncelli
2020-03-25 20:10 ` [PATCH 4/4] btrfs-progs: Add mixed profiles check to 'btrfs fi us' Goffredo Baroncelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=caf00fb2-cbf6-e9d4-7f5d-66a81d87b57d@libero.it \
    --to=kreijack@libero.it \
    --cc=ce3g8jdj@umail.furryterror.org \
    --cc=kreijack@inwind.it \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-BTRFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \
		linux-btrfs@vger.kernel.org
	public-inbox-index linux-btrfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git