From: fdmanana@kernel.org
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v3 0/2] btrfs: fix a deadlock between chunk allocation and chunk tree modifications
Date: Wed, 13 Oct 2021 10:12:48 +0100 [thread overview]
Message-ID: <cover.1634115580.git.fdmanana@suse.com> (raw)
In-Reply-To: <cover.1633604360.git.fdmanana@suse.com>
From: Filipe Manana <fdmanana@suse.com>
This fixes a deadlock between a task allocating a metadata or data chunk
and a task that is modifying the chunk btree and it's not in a chunk
allocation or removal context. The first patch is the fix, the second one
just updates a couple comments and it's independent of the fix.
v2: Updated stale comment after the fix (patch 1/2).
v3: Moved the logic to reserve chunk space out of btrfs_search_slot() into
every path that modifies the chunk btree (which are the cases listed in
the change log of patch 1/2) and updated two more comments in patch 1/2.
Filipe Manana (2):
btrfs: fix deadlock between chunk allocation and chunk btree modifications
btrfs: update comments for chunk allocation -ENOSPC cases
fs/btrfs/block-group.c | 166 +++++++++++++++++++++++++++--------------
fs/btrfs/block-group.h | 2 +
fs/btrfs/relocation.c | 4 +
fs/btrfs/volumes.c | 15 +++-
4 files changed, 128 insertions(+), 59 deletions(-)
--
2.33.0
next prev parent reply other threads:[~2021-10-13 9:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 11:03 [PATCH 0/2] btrfs: fix a deadlock between chunk allocation and chunk tree modifications fdmanana
2021-10-07 11:03 ` [PATCH 1/2] btrfs: fix deadlock between chunk allocation and chunk btree modifications fdmanana
2021-10-07 11:04 ` [PATCH 2/2] btrfs: update comments for chunk allocation -ENOSPC cases fdmanana
2021-10-08 15:10 ` [PATCH v2 0/2] btrfs: fix a deadlock between chunk allocation and chunk tree modifications fdmanana
2021-10-08 15:10 ` [PATCH v2 1/2] btrfs: fix deadlock between chunk allocation and chunk btree modifications fdmanana
2021-10-11 16:05 ` Josef Bacik
2021-10-11 17:31 ` Filipe Manana
2021-10-11 17:42 ` Josef Bacik
2021-10-11 18:22 ` Filipe Manana
2021-10-11 18:31 ` Josef Bacik
2021-10-11 19:09 ` Filipe Manana
2021-10-12 21:34 ` Josef Bacik
2021-10-13 9:19 ` Filipe Manana
2021-10-08 15:10 ` [PATCH v2 2/2] btrfs: update comments for chunk allocation -ENOSPC cases fdmanana
2021-10-13 9:12 ` fdmanana [this message]
2021-10-13 9:12 ` [PATCH v3 1/2] btrfs: fix deadlock between chunk allocation and chunk btree modifications fdmanana
2021-10-13 14:09 ` Nikolay Borisov
2021-10-13 14:21 ` Filipe Manana
2021-10-18 16:22 ` David Sterba
2021-10-14 15:20 ` Josef Bacik
2021-10-13 9:12 ` [PATCH v3 2/2] btrfs: update comments for chunk allocation -ENOSPC cases fdmanana
2021-10-14 15:21 ` Josef Bacik
2021-10-18 16:33 ` [PATCH v3 0/2] btrfs: fix a deadlock between chunk allocation and chunk tree modifications David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1634115580.git.fdmanana@suse.com \
--to=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).