linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: fdmanana@kernel.org
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 0/3] btrfs: updates to error path for delayed dir index insertion failure
Date: Mon, 28 Aug 2023 09:06:41 +0100	[thread overview]
Message-ID: <cover.1693209858.git.fdmanana@suse.com> (raw)
In-Reply-To: <cover.1693207973.git.fdmanana@suse.com>

From: Filipe Manana <fdmanana@suse.com>

Some updates to the error path for delayed dir index insertion failure,
motivated by a recent syzbot report:

  https://lore.kernel.org/linux-btrfs/00000000000036e1290603e097e0@google.com/

Details in the changelogs.

v2: Fixed error path in patch 2 to release delayed item before unlocking
    the delayed node. Added patch 3 to prevent such mistakes in the future.

Filipe Manana (3):
  btrfs: improve error message after failure to add delayed dir index item
  btrfs: remove BUG() after failure to insert delayed dir index item
  btrfs: assert delayed node locked when removing delayed item

 fs/btrfs/delayed-inode.c | 85 ++++++++++++++++++++++++++--------------
 1 file changed, 55 insertions(+), 30 deletions(-)

-- 
2.40.1


  parent reply	other threads:[~2023-08-28  8:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28  7:37 [PATCH 0/2] btrfs: updates to error path for delayed dir index insertion failure fdmanana
2023-08-28  7:37 ` [PATCH 1/2] btrfs: improve error message after failure to add delayed dir index item fdmanana
2023-08-28  7:37 ` [PATCH 2/2] btrfs: remove BUG() after failure to insert " fdmanana
2023-08-28  8:06 ` fdmanana [this message]
2023-08-28  8:06   ` [PATCH v2 1/3] btrfs: improve error message after failure to add " fdmanana
2023-08-28  8:34     ` Qu Wenruo
2023-08-28  8:06   ` [PATCH v2 2/3] btrfs: remove BUG() after failure to insert " fdmanana
2023-08-28  8:42     ` Qu Wenruo
2023-08-28  8:53       ` Filipe Manana
2023-08-28  9:18         ` Qu Wenruo
2023-08-28  8:06   ` [PATCH v2 3/3] btrfs: assert delayed node locked when removing delayed item fdmanana
2023-08-28  8:45     ` Qu Wenruo
2023-09-05 12:38   ` [PATCH v2 0/3] btrfs: updates to error path for delayed dir index insertion failure David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1693209858.git.fdmanana@suse.com \
    --to=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).