linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/7] btrfs: use i_size_read() instead of open code
Date: Tue, 7 Nov 2017 07:44:59 +0800	[thread overview]
Message-ID: <d16fbeb8-bfb7-58da-4ae0-6dde21a74762@oracle.com> (raw)
In-Reply-To: <20171106165215.GQ28789@twin.jikos.cz>



On 11/07/2017 12:52 AM, David Sterba wrote:
> On Mon, Nov 06, 2017 at 04:36:14PM +0800, Anand Jain wrote:
>> As i_size_read() takes care of 32bit smp or preempt cases as well.
> 
> Can bdev->bd_inode->i_size change so that we need to use the
> i_size_read()? My answer is 'no'.

  Hm. Right I was looking at it only from the theoretical point of view.

  And I presume you mean to say disk resize at the block layer is not
  really a practically achievable concern.

Thanks, Anand

  reply	other threads:[~2017-11-06 23:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06  8:36 [PATCH 0/8] Misc device cleanup patches: part1 Anand Jain
2017-11-06  8:36 ` [PATCH 1/7] btrfs: optimize use of volume_mutex in btrfs_ioctl_resize() Anand Jain
2017-11-06 16:50   ` David Sterba
2017-11-06  8:36 ` [PATCH 2/7] btrfs: move user provided string checks outside of volume_mutex Anand Jain
2017-11-06  8:36 ` [PATCH 3/7] btrfs: use i_size_read() instead of open code Anand Jain
2017-11-06 16:52   ` David Sterba
2017-11-06 23:44     ` Anand Jain [this message]
2017-11-15 16:45       ` David Sterba
2017-11-06  8:36 ` [PATCH 4/7] btrfs: rename btrfs_add_device to btrfs_add_dev_item Anand Jain
2017-11-06 16:53   ` David Sterba
2017-11-06  8:36 ` [PATCH 5/7] btrfs: btrfs_rm_device() does not need uuid_mutex Anand Jain
2017-11-06 17:02   ` David Sterba
2017-11-06 23:59     ` Anand Jain
2017-11-06  8:36 ` [PATCH 6/7] btrfs: move volume_mutex into btrfs_init_new_device() Anand Jain
2017-11-06  8:36 ` [PATCH 7/7] btrfs: rename btrfs_init_new_device() to btrfs_add_device() Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d16fbeb8-bfb7-58da-4ae0-6dde21a74762@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).