From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17FBC0044C for ; Wed, 7 Nov 2018 06:38:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96AE02081D for ; Wed, 7 Nov 2018 06:38:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96AE02081D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-btrfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbeKGQHp (ORCPT ); Wed, 7 Nov 2018 11:07:45 -0500 Received: from mout.gmx.net ([212.227.15.19]:37513 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726194AbeKGQHp (ORCPT ); Wed, 7 Nov 2018 11:07:45 -0500 Received: from [0.0.0.0] ([210.140.77.29]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0M2ts6-1fTyLc0tGA-00sgU5; Wed, 07 Nov 2018 07:38:43 +0100 Received: from [0.0.0.0] ([210.140.77.29]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0M2ts6-1fTyLc0tGA-00sgU5; Wed, 07 Nov 2018 07:38:43 +0100 Subject: Re: [PATCH 11/13] btrfs-progs: check: Delete file extent item with unaligned extent backref To: "Su Yanjun " , Su Yue , linux-btrfs@vger.kernel.org References: <20181023094147.7906-1-suy.fnst@cn.fujitsu.com> <20181023094147.7906-12-suy.fnst@cn.fujitsu.com> <18e31f91-74ef-1416-8b87-32a108700269@gmx.com> <24a149df-1b5d-8c9d-2f4d-37e2338a6c8a@cn.fujitsu.com> From: Qu Wenruo Openpgp: preference=signencrypt Autocrypt: addr=quwenruo.btrfs@gmx.com; prefer-encrypt=mutual; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNIlF1IFdlbnJ1byA8cXV3ZW5ydW8uYnRyZnNAZ214LmNvbT7CwJQEEwEIAD4CGwMFCwkI BwIGFQgJCgsCBBYCAwECHgECF4AWIQQt33LlpaVbqJ2qQuHCPZHzoSX+qAUCWdWCnQUJCWYC bgAKCRDCPZHzoSX+qAR8B/94VAsSNygx1C6dhb1u1Wp1Jr/lfO7QIOK/nf1PF0VpYjTQ2au8 ihf/RApTna31sVjBx3jzlmpy+lDoPdXwbI3Czx1PwDbdhAAjdRbvBmwM6cUWyqD+zjVm4RTG rFTPi3E7828YJ71Vpda2qghOYdnC45xCcjmHh8FwReLzsV2A6FtXsvd87bq6Iw2axOHVUax2 FGSbardMsHrya1dC2jF2R6n0uxaIc1bWGweYsq0LXvLcvjWH+zDgzYCUB0cfb+6Ib/ipSCYp 3i8BevMsTs62MOBmKz7til6Zdz0kkqDdSNOq8LgWGLOwUTqBh71+lqN2XBpTDu1eLZaNbxSI ilaVzsBNBFnVga8BCACqU+th4Esy/c8BnvliFAjAfpzhI1wH76FD1MJPmAhA3DnX5JDORcga CbPEwhLj1xlwTgpeT+QfDmGJ5B5BlrrQFZVE1fChEjiJvyiSAO4yQPkrPVYTI7Xj34FnscPj /IrRUUka68MlHxPtFnAHr25VIuOS41lmYKYNwPNLRz9Ik6DmeTG3WJO2BQRNvXA0pXrJH1fN GSsRb+pKEKHKtL1803x71zQxCwLh+zLP1iXHVM5j8gX9zqupigQR/Cel2XPS44zWcDW8r7B0 q1eW4Jrv0x19p4P923voqn+joIAostyNTUjCeSrUdKth9jcdlam9X2DziA/DHDFfS5eq4fEv ABEBAAHCwHwEGAEIACYWIQQt33LlpaVbqJ2qQuHCPZHzoSX+qAUCWdWBrwIbDAUJA8JnAAAK CRDCPZHzoSX+qA3xB/4zS8zYh3Cbm3FllKz7+RKBw/ETBibFSKedQkbJzRlZhBc+XRwF61mi f0SXSdqKMbM1a98fEg8H5kV6GTo62BzvynVrf/FyT+zWbIVEuuZttMk2gWLIvbmWNyrQnzPl mnjK4AEvZGIt1pk+3+N/CMEfAZH5Aqnp0PaoytRZ/1vtMXNgMxlfNnb96giC3KMR6U0E+siA 4V7biIoyNoaN33t8m5FwEwd2FQDG9dAXWhG13zcm9gnk63BN3wyCQR+X5+jsfBaS4dvNzvQv h8Uq/YGjCoV1ofKYh3WKMY8avjq25nlrhzD/Nto9jHp8niwr21K//pXVA81R2qaXqGbql+zo Message-ID: Date: Wed, 7 Nov 2018 14:38:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <24a149df-1b5d-8c9d-2f4d-37e2338a6c8a@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:JD6NALEeJLGv/cMd91pssjfEy64/Fmnw4D4Fz9W28ftLw3Kcy1D +vH/m5JGKPoDYui13lQwiS37mXOpnH0rIZgu0wWSd1m6IYBBDdoeiyhip24ma0zY1TP1ZAE cSFG7f9l9L9UbkMjbYFj3QHPQ8jmvY0NfCeG9YZ8lp5+upeKCAq9nXKMLygguYmERPLiaz6 9l6DoY8p3jD65PLKUW5DA== X-UI-Out-Filterresults: notjunk:1;V01:K0:hZkM7jcow9U=:tEerszIkzQuLT2kzNRGeSO Fv9j8y7mWfGaNBTe7k6jJU2w3SNLsof7LouMOF9n8dD973erEzKSc0rqx67qAOrb/58gGE7po oX7QZmdda6Aapind9R1uX0t9hHGMwKn2Wt9nSz65OCZbBUPiizqHUg5q5keTj5DBn5H1fKQde LSDmTTwmHS/mulMjPj92l84BblDeahcQyDxNPb5AS6K9SyIKqsqjsfEOw4i4flJ5nSf7AQtaq DIZL6VcVCoU4JF8yRzX1nJazmcwnc82DoOHRCJGRQPQSrUTFkPbwJaziVEyXupJy+05DjNgee 5bw0GLr4YgCevcjBTeGGcx094MoQl/mvlmkFJ0O97LLMpubebDLE2rOate4L/xst1/Rll7ONb 9r8yZvbhTJmoVuGh6QfXkfT3cNyg6vRQV8HCpZe264eRRGryAuaYnKkefC93JUMkhpEzdPrhs kKZEfM+qfUpwKwWwMzlG19FhwpHy6ojFhh2Tp8erlCgs8Wh5DlHrF1KIYl7zQ3EVhrjcZw0S0 eJaMBqwVWSRuBdRRKUYWWseohuIFUzz+zWvzuzLjndMlWbbvGwixljPd8OzPpEGUbuVO9ItlG YKjk4UUXK4vY/exKyHxvumb+/3mxnqud8ZiUWaNa0EhjtM3svS+MIWauRBWOVtgAjIcUYVoYC yXn9Qhh6P4I2Ruf6ElyHnOmN9sLUm479+Sm9bb1tG3S71RwMB5qDga01ceC41JhfjOVUKOx6r xmGdVtUE0xNMFlDJ7xi86/izbPjgYOUSemJnXBcqKsQuAl3L+nR/Xr8GMeEt9DwLDpSDvLM0/ mOaugp2uvsOrozQ8tSp+YoUr2tGy3XrrYSYf/1M1uGBa5X7jps= Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 2018/11/7 下午2:21, Su Yanjun wrote: > > > On 10/24/2018 8:45 AM, Qu Wenruo wrote: >> >> On 2018/10/23 下午5:41, Su Yue wrote: >>> From: Su Yanjun >>> >>> In original mode, if some file extent item has unaligned extent backref, >>> fixup_extent_refs can't repair it. This patch will check extent >>> alignment >>> then delete file extent with unaligned extent backref. >> This looks a little strange to me. >> >> You mean, an unaligned FILE EXTENT has an unaligned EXTENT_ITEM? >> >> Then why not just delete the EXTENT_ITEM directly? No need to go back >> checking if it has a corresponding EXTENT_DATA since unaligned one is >> definitely corrupted. >> >> For corrupted EXTENT_DATA, it should get deleted when we check fs tree. >> >> This would save you a lot of codes. >> >> Thanks, >> Qu > The situation is that the file extent has wrong extent backref, actually > it doesn't exist. Did you mean extent EXTENT_ITEM key's objectid is unaligned? Would you please give an example on this case? Like: ( EXTENT_DATA disk bytenr disk len And its backref like: ( EXTENT_ITEM ) And then mark where the number is incorrect. Thanks, Qu > > Thanks, > Su > > > > >