From: "Daniel Xu" <dxu@dxuuu.xyz>
To: linux-btrfs@vger.kernel.org, dsterba@suse.cz,
"Josef Bacik" <josef@toxicpanda.com>
Cc: "Kernel Team" <kernel-team@fb.com>
Subject: Re: [PATCH v2] btrfs-progs: restore: Have -l display subvolume name
Date: Tue, 10 Nov 2020 17:36:59 -0800 [thread overview]
Message-ID: <ee82ab2e-2464-406e-af3f-732874714869@www.fastmail.com> (raw)
In-Reply-To: <f4cf625aa2a0e52f722c7e1e92dc04906e1049dc.1604014245.git.dxu@dxuuu.xyz>
On Thu, Oct 29, 2020, at 4:33 PM, Daniel Xu wrote:
> This commit has `btrfs restore -l ...` display subvolume names if
> applicable. Before, it only listed subvolume IDs which are not very
> helpful for the user. A subvolume name is much more descriptive.
>
> Before:
> $ btrfs restore ~/scratch/btrfs/fs -l
> tree key (EXTENT_TREE ROOT_ITEM 0) 30425088 level 0
> tree key (DEV_TREE ROOT_ITEM 0) 30441472 level 0
> tree key (FS_TREE ROOT_ITEM 0) 30736384 level 0
> tree key (CSUM_TREE ROOT_ITEM 0) 30474240 level 0
> tree key (UUID_TREE ROOT_ITEM 0) 30785536 level 0
> tree key (256 ROOT_ITEM 0) 30818304 level 0
> tree key (257 ROOT_ITEM 0) 30883840 level 0
> tree key (DATA_RELOC_TREE ROOT_ITEM 0) 30490624 level 0
>
> After:
> $ ./btrfs restore ~/scratch/btrfs/fs -l
> tree key (EXTENT_TREE ROOT_ITEM 0) 30425088 level 0
> tree key (DEV_TREE ROOT_ITEM 0) 30441472 level 0
> tree key (FS_TREE ROOT_ITEM 0) 30736384 level 0
> tree key (CSUM_TREE ROOT_ITEM 0) 30474240 level 0
> tree key (UUID_TREE ROOT_ITEM 0) 30785536 level 0
> tree key (256 ROOT_ITEM 0) 30818304 level 0 subvol1
> tree key (257 ROOT_ITEM 0) 30883840 level 0 subvol2
> tree key (DATA_RELOC_TREE ROOT_ITEM 0) 30490624 level 0
>
> Link: https://github.com/kdave/btrfs-progs/issues/289
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---
> v1 -> v2:
> * moved get_subvol_name() to common/utils.c
> * check return from get_subvol_name() for errors
>
> cmds/restore.c | 14 +++++++++++++-
> common/utils.c | 35 +++++++++++++++++++++++++++++++++++
> common/utils.h | 1 +
> 3 files changed, 49 insertions(+), 1 deletion(-)
>
[...]
Ping
next prev parent reply other threads:[~2020-11-11 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 23:33 [PATCH v2] btrfs-progs: restore: Have -l display subvolume name Daniel Xu
2020-11-11 1:36 ` Daniel Xu [this message]
2020-11-13 21:08 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee82ab2e-2464-406e-af3f-732874714869@www.fastmail.com \
--to=dxu@dxuuu.xyz \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).