From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D595DC3A5A5 for ; Tue, 3 Sep 2019 05:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A89DC2173E for ; Tue, 3 Sep 2019 05:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726062AbfICFA0 (ORCPT ); Tue, 3 Sep 2019 01:00:26 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:8030 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725440AbfICFAZ (ORCPT ); Tue, 3 Sep 2019 01:00:25 -0400 X-IronPort-AV: E=Sophos;i="5.64,461,1559491200"; d="scan'208";a="74745103" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 03 Sep 2019 13:00:23 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id 4CA174CE14E4; Tue, 3 Sep 2019 13:00:20 +0800 (CST) Received: from [10.167.225.140] (10.167.225.140) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Sep 2019 13:00:27 +0800 Subject: Re: [PATCH v3 0/15] Btrfs iomap To: "Darrick J. Wong" CC: Christoph Hellwig , Goldwyn Rodrigues , , , , References: <20190901200836.14959-1-rgoldwyn@suse.de> <20190902164331.GE6263@lst.de> <4d039e8e-dc35-8092-4ee0-4a2e0f43f233@cn.fujitsu.com> <20190903042935.GD5340@magnolia> From: Shiyang Ruan Message-ID: Date: Tue, 3 Sep 2019 13:00:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190903042935.GD5340@magnolia> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.225.140] X-yoursite-MailScanner-ID: 4CA174CE14E4.AC634 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: ruansy.fnst@cn.fujitsu.com Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 9/3/19 12:29 PM, Darrick J. Wong wrote: > On Tue, Sep 03, 2019 at 11:51:24AM +0800, Shiyang Ruan wrote: >> >> >> On 9/3/19 12:43 AM, Christoph Hellwig wrote: >>> On Sun, Sep 01, 2019 at 03:08:21PM -0500, Goldwyn Rodrigues wrote: >>>> This is an effort to use iomap for btrfs. This would keep most >>>> responsibility of page handling during writes in iomap code, hence >>>> code reduction. For CoW support, changes are needed in iomap code >>>> to make sure we perform a copy before the write. >>>> This is in line with the discussion we had during adding dax support in >>>> btrfs. >>> >>> This looks pretty good modulo a few comments. >>> >>> Can you please convert the XFS code to use your two iomaps for COW >>> approach as well to validate it? >> >> Hi, >> >> The XFS part of dax CoW support has been implementing recently. Please >> review this[1] if necessary. It's based on this iomap patchset(the 1st >> version), and uses the new srcmap. >> >> [1]: https://lkml.org/lkml/2019/7/31/449 > > It sure would be nice to have (a) this patchset of Goldwyn's cleaned up > a bit per the review comments and (b) the XFS DAX COW series rebased on > that (instead of a month-old submission). ;) Yes, I think so too. Just in case Christoph did not notice that. -- Thanks, Shiyang Ruan. > > --D > >> -- >> Thanks, >> Shiyang Ruan. >>> >>> Also the iomap_file_dirty helper would really benefit from using the >>> two iomaps, any chance you could look into improving it to use your >>> new infrastructure? >>> >>> >> >> >> > >