From: Nikolay Borisov <nborisov@suse.com>
To: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 2/5] btrfs: Account for trans_block_rsv in may_commit_transaction
Date: Mon, 9 Mar 2020 22:44:38 +0200 [thread overview]
Message-ID: <f0b3d7ca-0f9b-b49f-9766-f70045ab366a@suse.com> (raw)
In-Reply-To: <20200309202322.12327-3-josef@toxicpanda.com>
On 9.03.20 г. 22:23 ч., Josef Bacik wrote:
> On ppc64le with 64k page size (respectively 64k block size) generic/320
> was failing and debug output showed we were getting a premature ENOSPC
> with a bunch of space in btrfs_fs_info::trans_block_rsv.
>
> This meant there were still open transaction handles holding space, yet
> the flusher didn't commit the transaction because it deemed the freed
> space won't be enough to satisfy the current reserve ticket. Fix this
> by accounting for space in trans_block_rsv when deciding whether the
> current transaction should be committed or not.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2020-03-09 20:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 20:23 [PATCH 0/5] Deal with a few ENOSPC corner cases Josef Bacik
2020-03-09 20:23 ` [PATCH 1/5] btrfs: Improve global reserve stealing logic Josef Bacik
2020-03-09 20:48 ` Nikolay Borisov
2020-03-10 14:27 ` Nikolay Borisov
2020-03-09 20:23 ` [PATCH 2/5] btrfs: Account for trans_block_rsv in may_commit_transaction Josef Bacik
2020-03-09 20:44 ` Nikolay Borisov [this message]
2020-03-09 20:23 ` [PATCH 3/5] btrfs: only take normal tickets into account " Josef Bacik
2020-03-09 20:51 ` Nikolay Borisov
2020-03-09 23:13 ` Nikolay Borisov
2020-03-10 10:27 ` Nikolay Borisov
2020-03-09 20:23 ` [PATCH 4/5] btrfs: only check priority tickets for priority flushing Josef Bacik
2020-03-10 10:30 ` Nikolay Borisov
2020-03-09 20:23 ` [PATCH 5/5] btrfs: run btrfs_try_granting_tickets if a priority ticket fails Josef Bacik
2020-03-10 10:32 ` Nikolay Borisov
2020-03-13 19:54 ` Josef Bacik
2020-03-10 17:28 ` [PATCH 0/5] Deal with a few ENOSPC corner cases Nikolay Borisov
2020-03-11 1:45 ` David Sterba
2020-03-13 12:37 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b3d7ca-0f9b-b49f-9766-f70045ab366a@suse.com \
--to=nborisov@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).