From: Qu Wenruo <wqu@suse.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Nick Terrell <terrelln@fb.com>,
Chris Down <chris@chrisdown.name>,
Filipe Manana <fdmanana@suse.com>,
Nikolay Borisov <nborisov@suse.com>,
Gabriel Niebler <gniebler@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH] btrfs: Convert zlib_compress_pages() to use kmap_local_page()
Date: Sun, 26 Jun 2022 07:03:55 +0800 [thread overview]
Message-ID: <f65fd4fb-675a-3f9e-accb-77db9ad7d551@suse.com> (raw)
In-Reply-To: <3110135.5fSG56mABF@opensuse>
On 2022/6/25 22:41, Fabio M. De Francesco wrote:
> On sabato 18 giugno 2022 11:27:52 CEST Fabio M. De Francesco wrote:
>> The use of kmap() is being deprecated in favor of kmap_local_page(). With
>> kmap_local_page(), the mapping is per thread, CPU local and not globally
>> visible.
>>
>> Therefore, use kmap_local_page() / kunmap_local() in
> zlib_compress_pages()
>> because in this function the mappings are per thread and are not visible
>> in other contexts.
>>
>> Tested with xfstests on QEMU + KVM 32-bit VM with 4GB of RAM and
>> HIGHMEM64G enabled. This patch passes 26/26 tests of group "compress".
>>
>> Cc: Qu Wenruo <wqu@suse.com>
>> Suggested-by: Ira Weiny <ira.weiny@intel.com>
>> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>> ---
>>
>> This patch builds only on top of
>> "[PATCH] btrfs: zlib: refactor how we prepare the input buffer" by Qu
> Wenruo".
>> https://lore.kernel.org/linux-btrfs/
> d0bfc791b5509df7b9ad44e41ada197d1b3149b3.1655519730.git.wqu@suse.com/
>>
>
> I've seen that Qu sent a v2 of the above patch. However David thinks that
> it is better not to map pages allocated in zlib.c for output (out_page)
> since they cannot come from highmem because of "alloc_page(GFP_NOFS);".
>
> @David:
>
> I suppose that, since it builds _only_ on top of the refactor submitted by
> Qu, I'll have to wait and see what you decide.
>
> If you don't want kmap_local_page() and prefer using page_address() on
> "out_page", please drop this patch and let me know, so that I can send a
> new patch which will be in accordance to your preference.
And that would also make the convert much easier for kmap_local_page()
of input pages.
I'll hold the refactor patch after all the kmap code is converted.
Thanks,
Qu
>
> Thanks,
>
> Fabio
>
>
next prev parent reply other threads:[~2022-06-25 23:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 9:27 [PATCH] btrfs: Convert zlib_compress_pages() to use kmap_local_page() Fabio M. De Francesco
2022-06-25 14:41 ` Fabio M. De Francesco
2022-06-25 23:03 ` Qu Wenruo [this message]
2022-06-26 11:12 ` Fabio M. De Francesco
2022-06-27 16:41 ` Fabio M. De Francesco
2022-06-27 16:33 Fabio M. De Francesco
2022-06-30 14:51 ` Ira Weiny
2022-07-07 21:17 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f65fd4fb-675a-3f9e-accb-77db9ad7d551@suse.com \
--to=wqu@suse.com \
--cc=chris@chrisdown.name \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=fmdefrancesco@gmail.com \
--cc=gniebler@suse.com \
--cc=ira.weiny@intel.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).