From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: qgroup: Remove duplicated trace points for qgroup_rsv_add/release()
Date: Tue, 13 Nov 2018 11:52:09 +0200 [thread overview]
Message-ID: <f84177eb-e789-97fc-396c-ec3c6a4e9306@suse.com> (raw)
In-Reply-To: <20181113070508.3463-1-wqu@suse.com>
On 13.11.18 г. 9:05 ч., Qu Wenruo wrote:
> Inside qgroup_rsv_add/release(), we have trace events
> trace_qgroup_update_reserve() to catch reserved space update.
>
> However we still have two manual trace_qgroup_update_reserve() calls
> just outside these functions.
>
> Remove these duplicated calls.
>
> Fixes: 64ee4e751a1c ("btrfs: qgroup: Update trace events to use new separate rsv types")
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/qgroup.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index 45868fd76209..c1fbd8a30fc4 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -2952,7 +2952,6 @@ static int qgroup_reserve(struct btrfs_root *root, u64 num_bytes, bool enforce,
>
> qg = unode_aux_to_qgroup(unode);
>
> - trace_qgroup_update_reserve(fs_info, qg, num_bytes, type);
> qgroup_rsv_add(fs_info, qg, num_bytes, type);
> }
>
> @@ -3019,7 +3018,6 @@ void btrfs_qgroup_free_refroot(struct btrfs_fs_info *fs_info,
>
> qg = unode_aux_to_qgroup(unode);
>
> - trace_qgroup_update_reserve(fs_info, qg, -(s64)num_bytes, type);
> qgroup_rsv_release(fs_info, qg, num_bytes, type);
>
> list_for_each_entry(glist, &qg->groups, next_group) {
>
next prev parent reply other threads:[~2018-11-13 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 7:05 [PATCH] btrfs: qgroup: Remove duplicated trace points for qgroup_rsv_add/release() Qu Wenruo
2018-11-13 9:52 ` Nikolay Borisov [this message]
2019-01-30 16:57 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f84177eb-e789-97fc-396c-ec3c6a4e9306@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).