Re: fix read repair on compressed extents v3

[Nikolay Borisov <nborisov@suse.com>]

On 7.07.22 г. 8:33 ч., Christoph Hellwig wrote:
> Hi all,
> 
> while looking into the repair code I found that read repair of compressed
> extents is current fundamentally broken, in that repair tries to write
> the uncompressed data into a corrupted extent during a repair.  This is
> demonstrated by the "btrfs: test read repair on a corrupted compressed
> extent" test submitted to xfstests.
> 
> This series fixes that, but is a bit invaside as it requires both
> refactoring of the compression code and changes to the repair code to
> not look up the logic address on every repair attempt.  On the plus
> side it removes a whole lot of code.
> 
> The series is on top of the for-next branch, as that includes other
> bio changes not in misc-next yet.
> 
> Changes since v2:
>   - include the previous submitted and reviewed repair all mirrors patch
>     to simplify the stack of patches
>   - include an additional cleanup patch at the end
>   - improve a commit log
>   
> Changes since v1:
>   - describe the partial revert that happens in patch 1 better in the
>     commit log
>   - drop a now incorrect comment
>   - do not add a prototype for a non-existent function
> 
> Diffstat:
>   compression.c |  287 ++++++++++++++++------------------------------------------
>   compression.h |   11 --
>   ctree.h       |    2
>   extent_io.c   |   93 +++++++-----------
>   extent_io.h   |    9 -
>   inode.c       |   34 +++---
>   volumes.h     |    2
>   7 files changed, 146 insertions(+), 292 deletions(-)
>   compression.c |  311 ++++++++++++++++------------------------------------------
>   compression.h |   11 --
>   ctree.h       |    4
>   extent_io.c   |  202 ++++++++++++++++---------------------
>   extent_io.h   |   10 -
>   inode.c       |   39 +++----
>   6 files changed, 203 insertions(+), 374 deletions(-)


For the whole series :

Reviewed-by: Nikolay Borisov <nborisov@suse.com>