From: Nikolay Borisov <nborisov@suse.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] btrfs: remove pointless out label in find_first_block_group
Date: Tue, 26 May 2020 18:24:49 +0300 [thread overview]
Message-ID: <fce3d7f8-23b8-b417-f5d3-3f6af7738118@suse.com> (raw)
In-Reply-To: <20200526142124.36202-2-johannes.thumshirn@wdc.com>
On 26.05.20 г. 17:21 ч., Johannes Thumshirn wrote:
> The 'out' label in find_first_block_group() does not do anything in terms
> of cleanup.
>
> It is better to directly return 'ret' instead of jumping to out to not
> confuse readers. Additionally there is no need to initialize ret with 0.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
I personally prefer returning fast aka the way you've done it but dunno
if David is a fan of this. In any case:
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2020-05-26 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 14:21 [PATCH 0/3] 3 small cleanups for find_first_block_group Johannes Thumshirn
2020-05-26 14:21 ` [PATCH 1/3] btrfs: remove pointless out label in find_first_block_group Johannes Thumshirn
2020-05-26 15:24 ` Nikolay Borisov [this message]
2020-05-27 9:31 ` David Sterba
2020-05-26 14:21 ` [PATCH 2/3] btrfs: get mapping tree directly from fsinfo " Johannes Thumshirn
2020-05-26 15:25 ` Nikolay Borisov
2020-05-26 14:21 ` [PATCH 3/3] btrfs: factor out reading of bg from find_frist_block_group Johannes Thumshirn
2020-05-26 15:33 ` Nikolay Borisov
2020-05-27 7:46 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fce3d7f8-23b8-b417-f5d3-3f6af7738118@suse.com \
--to=nborisov@suse.com \
--cc=dsterba@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).