From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.com, y16267966@gmail.com
Subject: Re: [PATCH v2 4/4] btrfs-progs: convert: support ext2 unwritten file data extents
Date: Thu, 9 May 2024 17:17:47 +0800 [thread overview]
Message-ID: <fd1e3e98-ec26-4c97-9b71-1a96f0d9cb9e@oracle.com> (raw)
In-Reply-To: <5da145c8-802d-4fd2-a52d-9a4c6fe37ea5@gmx.com>
On 5/7/24 09:25, Qu Wenruo wrote:
>
>
> 在 2024/5/6 12:34, Anand Jain 写道:
> [...]
>>
>> 18619b678a5c207a971a0aa931604f48162e307c57ecdec450d5f095fe9f32c7
>> /mnt/test/foo
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> v2:
>>
>> . Remove RFC
>
> Nope, you didn't even test the patch using the selftests.
> (Despite the RST introduced failure, the first ext2 is enough to expose
> your bug).
>
Realizing the existing test case missed testing unwritten extents,
I wrote my own, and they passed as expected. Later, I completely
forgot running the existing test cases, my bad.
Overall, the initial work inspired better designs. I'm glad the
issue was resolved.
prev parent reply other threads:[~2024-05-09 9:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 3:04 [PATCH v2 0/4] btrfs-progs: add support ext4 unwritten file extent Anand Jain
2024-05-06 3:04 ` [PATCH v2 1/4] btrfs-progs: convert: refactor ext2_create_file_extents add argument ext2_inode Anand Jain
2024-05-06 3:04 ` [PATCH v2 2/4] btrfs-progs: convert: struct blk_iterate_data, add ext2-specific file inode pointers Anand Jain
2024-05-06 3:04 ` [PATCH v2 3/4] btrfs-progs: convert: refactor __btrfs_record_file_extent to add a prealloc flag Anand Jain
2024-05-06 3:04 ` [PATCH v2 4/4] btrfs-progs: convert: support ext2 unwritten file data extents Anand Jain
2024-05-06 5:41 ` Qu Wenruo
2024-05-06 5:59 ` Qu Wenruo
2024-05-06 9:56 ` Anand Jain
2024-05-06 10:25 ` Qu Wenruo
2024-05-07 1:25 ` Qu Wenruo
2024-05-09 9:17 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1e3e98-ec26-4c97-9b71-1a96f0d9cb9e@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=y16267966@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).