linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] btrfs: simplify workqueue name when allocating
@ 2019-01-17 16:15 David Sterba
  2019-01-17 16:17 ` Nikolay Borisov
  0 siblings, 1 reply; 2+ messages in thread
From: David Sterba @ 2019-01-17 16:15 UTC (permalink / raw)
  To: linux-btrfs; +Cc: David Sterba

The workqueue name is constructed from a format string but the prefix
does not need to be set by %s.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/async-thread.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
index 44a7942f0457..92dfc70f9511 100644
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-thread.c
@@ -127,13 +127,11 @@ __btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info, const char *name,
 	}
 
 	if (flags & WQ_HIGHPRI)
-		ret->normal_wq = alloc_workqueue("%s-%s-high", flags,
-						 ret->current_active, "btrfs",
-						 name);
+		ret->normal_wq = alloc_workqueue("btrfs-%s-high", flags,
+						 ret->current_active, name);
 	else
-		ret->normal_wq = alloc_workqueue("%s-%s", flags,
-						 ret->current_active, "btrfs",
-						 name);
+		ret->normal_wq = alloc_workqueue("btrfs-%s", flags,
+						 ret->current_active, name);
 	if (!ret->normal_wq) {
 		kfree(ret);
 		return NULL;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs: simplify workqueue name when allocating
  2019-01-17 16:15 [PATCH] btrfs: simplify workqueue name when allocating David Sterba
@ 2019-01-17 16:17 ` Nikolay Borisov
  0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Borisov @ 2019-01-17 16:17 UTC (permalink / raw)
  To: David Sterba, linux-btrfs



On 17.01.19 г. 18:15 ч., David Sterba wrote:
> The workqueue name is constructed from a format string but the prefix
> does not need to be set by %s.
> 
> Signed-off-by: David Sterba <dsterba@suse.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  fs/btrfs/async-thread.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
> index 44a7942f0457..92dfc70f9511 100644
> --- a/fs/btrfs/async-thread.c
> +++ b/fs/btrfs/async-thread.c
> @@ -127,13 +127,11 @@ __btrfs_alloc_workqueue(struct btrfs_fs_info *fs_info, const char *name,
>  	}
>  
>  	if (flags & WQ_HIGHPRI)
> -		ret->normal_wq = alloc_workqueue("%s-%s-high", flags,
> -						 ret->current_active, "btrfs",
> -						 name);
> +		ret->normal_wq = alloc_workqueue("btrfs-%s-high", flags,
> +						 ret->current_active, name);
>  	else
> -		ret->normal_wq = alloc_workqueue("%s-%s", flags,
> -						 ret->current_active, "btrfs",
> -						 name);
> +		ret->normal_wq = alloc_workqueue("btrfs-%s", flags,
> +						 ret->current_active, name);
>  	if (!ret->normal_wq) {
>  		kfree(ret);
>  		return NULL;
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-17 16:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 16:15 [PATCH] btrfs: simplify workqueue name when allocating David Sterba
2019-01-17 16:17 ` Nikolay Borisov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).