From: Johannes Thumshirn <jthumshirn@suse.de>
To: dsterba@suse.cz, David Sterba <dsterba@suse.com>,
Nikolay Borisov <nborisov@suse.com>, Qu Wenruo <wqu@suse.com>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] btrfs: reset device back to allocation state when removing
Date: Thu, 28 Nov 2019 10:29:42 +0100 [thread overview]
Message-ID: <fe0e706b-1431-743c-bc6f-042fcd81ed08@suse.de> (raw)
In-Reply-To: <20191127170749.GW2734@twin.jikos.cz>
On 27/11/2019 18:07, David Sterba wrote:
> On Tue, Nov 26, 2019 at 09:40:06AM +0100, Johannes Thumshirn wrote:
>> + ASSERT(atomic_read(&device->dev_stats_ccnt) == 0);
>
> btrfs/020 [16:59:58][ 3477.975072] run fstests btrfs/020 at 2019-11-27 16:59:58
> [ 3478.974314] kworker/dying (5607) used greatest stack depth: 10792 bytes left
> [ 3479.206988] BTRFS: device fsid 818a4909-467d-4599-979c-3b258fb4fc41 devid 1 transid 5 /dev/loop0 scanned by mkfs.btrfs (27347)
> [ 3479.234212] BTRFS: device fsid 818a4909-467d-4599-979c-3b258fb4fc41 devid 2 transid 5 /dev/loop1 scanned by mkfs.btrfs (27347)
> [ 3479.343996] BTRFS info (device loop0): disk space caching is enabled
> [ 3479.349590] BTRFS info (device loop0): has skinny extents
> [ 3479.352721] BTRFS info (device loop0): flagging fs with big metadata feature
> [ 3479.360793] BTRFS info (device loop0): enabling ssd optimizations
> [ 3479.614065] assertion failed: atomic_read(&device->dev_stats_ccnt) == 0, in fs/btrfs/volumes.c:1093
> [ 3479.622041] ------------[ cut here ]------------
> [ 3479.625272] kernel BUG at fs/btrfs/ctree.h:3118!
My test setup was missing loopback device support, fixed that.
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2019-11-28 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 8:40 [PATCH v4 0/2] remove BUG_ON()s in btrfs_close_one_device() Johannes Thumshirn
2019-11-26 8:40 ` [PATCH v4 1/2] btrfs: decrement number of open devices after closing the device not before Johannes Thumshirn
2019-11-26 8:40 ` [PATCH v4 2/2] btrfs: reset device back to allocation state when removing Johannes Thumshirn
2019-11-26 10:21 ` Nikolay Borisov
2019-11-26 17:17 ` David Sterba
2019-11-27 15:26 ` David Sterba
2019-11-27 17:07 ` David Sterba
2019-11-28 9:29 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe0e706b-1431-743c-bc6f-042fcd81ed08@suse.de \
--to=jthumshirn@suse.de \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).