linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Sriram Dash" <sriram.dash@samsung.com>
To: "'Marc Kleine-Budde'" <mkl@pengutronix.de>, <linux-can@vger.kernel.org>
Cc: "'Dan Murphy'" <dmurphy@ti.com>,
	"'Mario Huettel'" <mario.huettel@gmx.net>,
	"'Quentin Schulz'" <quentin.schulz@free-electrons.com>
Subject: RE: [net] can: m_can: fix nominal bitiming tseg2 min for version >= 3.1
Date: Wed, 25 Nov 2020 14:25:59 +0530	[thread overview]
Message-ID: <012701d6c308$ccec20f0$66c462d0$@samsung.com> (raw)
In-Reply-To: <20201124190751.3972238-1-mkl@pengutronix.de>

> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Subject: [net] can: m_can: fix nominal bitiming tseg2 min for version >=
3.1
> 
> At lest the revision 3.3.0 of the bosch m_can IP core specifies that valid
> register values for "Nominal Time segment after sample point (NTSEG2)" are
> from
> 1 to 127. As the hardware uses a value of one more than the programmed
> value, mean tseg2_min is 2.
> 
> This patch fixes the tseg2_min value accordingly.
>

Acked-by: Sriram Dash <sriram.dash@samsung.com>

> Cc: Dan Murphy <dmurphy@ti.com>
> Cc: Sriram Dash <sriram.dash@samsung.com>
> Cc: Mario Huettel <mario.huettel@gmx.net>
> Cc: Quentin Schulz <quentin.schulz@free-electrons.com>
> Fixes: b03cfc5bb0e1 ("can: m_can: Enable M_CAN version dependent
> initialization")
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  drivers/net/can/m_can/m_can.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/m_can/m_can.c
> b/drivers/net/can/m_can/m_can.c index f3fc37e96b08..86bbbfa2d743
> 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1033,7 +1033,7 @@ static const struct can_bittiming_const
> m_can_bittiming_const_31X = {
>  	.name = KBUILD_MODNAME,
>  	.tseg1_min = 2,		/* Time segment 1 = prop_seg + phase_seg1
> */
>  	.tseg1_max = 256,
> -	.tseg2_min = 1,		/* Time segment 2 = phase_seg2 */
> +	.tseg2_min = 2,		/* Time segment 2 = phase_seg2 */
>  	.tseg2_max = 128,
>  	.sjw_max = 128,
>  	.brp_min = 1,
> --
> 2.29.2
> 



      reply	other threads:[~2020-11-25  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20201124190800epcas5p4d5b22f8411d818ec422f24497e78328e@epcas5p4.samsung.com>
2020-11-24 19:07 ` Marc Kleine-Budde
2020-11-25  8:55   ` Sriram Dash [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='012701d6c308$ccec20f0$66c462d0$@samsung.com' \
    --to=sriram.dash@samsung.com \
    --cc=dmurphy@ti.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mario.huettel@gmx.net \
    --cc=mkl@pengutronix.de \
    --cc=quentin.schulz@free-electrons.com \
    --subject='RE: [net] can: m_can: fix nominal bitiming tseg2 min for version >= 3.1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox