linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: linux-can@vger.kernel.org
Cc: kernel@pengutronix.de, Dan Murphy <dmurphy@ti.com>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [net-rfc 03/12] can: tcan4x5x: replace depends on REGMAP_SPI with depends on SPI
Date: Mon, 19 Oct 2020 17:42:24 +0200	[thread overview]
Message-ID: <20201019154233.1262589-4-mkl@pengutronix.de> (raw)
In-Reply-To: <20201019154233.1262589-1-mkl@pengutronix.de>

From: Enric Balletbo i Serra <enric.balletbo@collabora.com>

regmap is a library function that gets selected by drivers that need it. No
driver modules should depend on it. Instead depends on SPI and select
REGMAP_SPI. Depending on REGMAP_SPI makes this driver only build if another
driver already selected REGMAP_SPI, as the symbol can't be selected through the
menu kernel configuration.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Link: http://lore.kernel.org/r/20200413141013.506613-1-enric.balletbo@collabora.com
Reviewed-by: Dan Murphy <dmurphy@ti.com>
Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/net/can/m_can/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
index 48be627c85c2..5f9f8192dd0b 100644
--- a/drivers/net/can/m_can/Kconfig
+++ b/drivers/net/can/m_can/Kconfig
@@ -16,7 +16,8 @@ config CAN_M_CAN_PLATFORM
 
 config CAN_M_CAN_TCAN4X5X
 	depends on CAN_M_CAN
-	depends on REGMAP_SPI
+	depends on SPI
+	select REGMAP_SPI
 	tristate "TCAN4X5X M_CAN device"
 	help
 	  Say Y here if you want support for Texas Instruments TCAN4x5x
-- 
2.28.0


  parent reply	other threads:[~2020-10-19 15:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 15:42 [RFC]: can 2020-10-19: m_can/tcan4x5x Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 01/12] can: m_can: remove double clearing of clock stop request bit Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 02/12] can: m_can: m_can_handle_state_change(): fix state change Marc Kleine-Budde
2020-10-19 15:42 ` Marc Kleine-Budde [this message]
2020-10-19 15:42 ` [net-rfc 04/12] can: tcan4x5x: tcan4x5x_clear_interrupts(): remove redundant return statement Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 05/12] can: tcan4x5x: Rename parse_config() function Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 06/12] can: tcan4x5x: tcan4x5x_can_probe(): add missing error checking for devm_regmap_init() Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 07/12] can: m_can: m_can_class_free_dev(): introduce new function Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 08/12] can: m_can: Fix freeing of can device from peripherials Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 09/12] can: m_can: tcan4x5x: tcan4x5x_can_remove(): fix order of deregistration Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 10/12] can: tcan4x5x: Move clock init to TCAN driver Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 11/12] can: m_can_platform: Move clock discovery and init to platform Marc Kleine-Budde
2020-10-19 15:42 ` [net-rfc 12/12] can: m_can: Remove unused clock function from the framework Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201019154233.1262589-4-mkl@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=dmurphy@ti.com \
    --cc=enric.balletbo@collabora.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).