From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5785C433E9 for ; Mon, 8 Mar 2021 16:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93EE46522F for ; Mon, 8 Mar 2021 16:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230135AbhCHQgC (ORCPT ); Mon, 8 Mar 2021 11:36:02 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:42085 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbhCHQfs (ORCPT ); Mon, 8 Mar 2021 11:35:48 -0500 Received: from localhost.localdomain ([153.202.107.157]) by mwinf5d09 with ME id dsbe2400Y3PnFJp03sbicU; Mon, 08 Mar 2021 17:35:45 +0100 X-ME-Helo: localhost.localdomain X-ME-Auth: bWFpbGhvbC52aW5jZW50QHdhbmFkb28uZnI= X-ME-Date: Mon, 08 Mar 2021 17:35:45 +0100 X-ME-IP: 153.202.107.157 From: Vincent Mailhol To: Marc Kleine-Budde , linux-can@vger.kernel.org Cc: Arunachalam Santhanam , Vincent Mailhol Subject: [PATCH v12 0/1] Introducing ETAS ES58X CAN USB interfaces Date: Tue, 9 Mar 2021 01:34:44 +0900 Message-Id: <20210308163445.103636-1-mailhol.vincent@wanadoo.fr> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Here comes the twelfth iteration of the ETAS es58x usb driver. The major difference from previous version is the total removal of spinlocks. Aside of that, I also implemented the TDC accordingly to the patch series which I submitted here two weeks ago. This patch series is based on linux-can-next/testing. It requires the latest patches in that branch to compile. Crossing fingers, hoping that we are now close to a release. Thank you in advance for your review and for your time! Yours sincerely, Vincent ** Change log ** Changes in v12 (2021-03-09): - Rework the queue stop/wake management so that spinlocks are not needed anymore. - es58x_start_xmit(): check for valid SKB using can_dropped_invalid_skb(). - Implemented TDC according to latest patches in linux-can-next. Reference: https://lore.kernel.org/linux-can/20210224002008.4158-1-mailhol.vincent@wanadoo.fr/T/#t Changes in v11 (2021-01-23): - Remove all WARN_ON() calls: these were use during development, relevant tests are done not to trigger these. - es58x_start_xmit(): added net_ratelimit() condition to prevent spamming dmesg. - add a new es58x_xmit_more() function and simplify the code of es58x_start_xmit(). - Removed functions {es581_4,es58x_fd}_print_conf() which were only there for debug. - Additional comment for es58x_fd_param.bitrate_max. - Make the device FIFO size a power of two and modify the echo_skb indexes logic to prevent the use of spinlocks. Changes in v10 (2021-01-12): - Rebased on linux-can-next/testing and modified according to latest BQL patches. Reference: https://lore.kernel.org/linux-can/20210111141930.693847-1-mkl@pengutronix.de/T/#m5f99d4da8e8934a75f9481ecc3137b59f3762413 - Replaced __netdev_sent_queue() by netdev_sent_queue(). Changes in v9 (2021-01-09): - es58x_start_xmit(): do not use skb anymore after the call of can_put_echo_skb(). Rationale: can_put_echo_skb() calls skb_clone() and thus the original skb gets consumed (i.e. use after free issue). - es58x_start_xmit(): Add a "drop_skb" label to free the skb when errors occur. Changes in v8 (2021-01-04): - The driver requires CRC16. Modified Kconfig accordingly. Changes in v7 (2020-11-17): - Fix compilation issue if CONFIG_BQL is not set. Reference: https://lkml.org/lkml/2020/11/15/163 Changes in v6 (2020-11-15): - Rebase the patch on the testing branch of linux-can-next. - Rename the helper functions according latest changes (e.g. can_cc_get_len() -> can_cc_dlc2len()) - Fix comments of enum es58x_physical_layer and enum es58x_sync_edge. Changes in v5 (2020-11-07): - Add support for DLC greater than 8. - All other patches from the previous series were either accepted or dismissed. As such, this is not a series any more but a single patch. Changes in v4 (2020-10-17): - Remove struct es58x_abstracted_can_frame. - Fix formatting (spaces, comment style). - Transform macros into static inline functions when possible. - Fix the ctrlmode_supported flags in es581_4.c and removed misleading comments in enum es58x_samples_per_bit. - Rename enums according to the type. - Remove function es58x_can_put_echo_skb(). Reference: https://lkml.org/lkml/2020/10/10/53 Changes in v3 (2020-10-03): - Remove all the calls to likely() and unlikely(). Reference: https://lkml.org/lkml/2020/9/30/995 Changes in v2 (2020-09-30): - Fixed -W1 warnings (v1 was tested with GCC -WExtra but not with -W1). v1 (2020-09-27): - First release Vincent Mailhol (1): can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces drivers/net/can/usb/Kconfig | 10 + drivers/net/can/usb/Makefile | 1 + drivers/net/can/usb/etas_es58x/Makefile | 3 + drivers/net/can/usb/etas_es58x/es581_4.c | 525 ++++ drivers/net/can/usb/etas_es58x/es581_4.h | 208 ++ drivers/net/can/usb/etas_es58x/es58x_core.c | 2404 +++++++++++++++++++ drivers/net/can/usb/etas_es58x/es58x_core.h | 690 ++++++ drivers/net/can/usb/etas_es58x/es58x_fd.c | 600 +++++ drivers/net/can/usb/etas_es58x/es58x_fd.h | 243 ++ 9 files changed, 4684 insertions(+) create mode 100644 drivers/net/can/usb/etas_es58x/Makefile create mode 100644 drivers/net/can/usb/etas_es58x/es581_4.c create mode 100644 drivers/net/can/usb/etas_es58x/es581_4.h create mode 100644 drivers/net/can/usb/etas_es58x/es58x_core.c create mode 100644 drivers/net/can/usb/etas_es58x/es58x_core.h create mode 100644 drivers/net/can/usb/etas_es58x/es58x_fd.c create mode 100644 drivers/net/can/usb/etas_es58x/es58x_fd.h -- 2.26.2