From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc: linux-can <linux-can@vger.kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH v2 4/5] can: add netlink interface for CAN-FD Transmitter Delay Compensation (TDC)
Date: Tue, 9 Mar 2021 14:19:21 +0100 [thread overview]
Message-ID: <20210309131921.7b5jhq3bak2yiv5w@pengutronix.de> (raw)
In-Reply-To: <CAMZ6RqLZ+LidnRka1-pX8dkHCaqNs3=bRujsMEs8LXnq0Y_E9Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2450 bytes --]
On 09.03.2021 22:16:45, Vincent MAILHOL wrote:
> On Wed. 24 Feb 2021 at 09:20, Vincent Mailhol
> <mailhol.vincent@wanadoo.fr> wrote:
> >
> > diff --git a/drivers/net/can/dev/netlink.c b/drivers/net/can/dev/netlink.c
> > index c19eef775ec8..c3f75c09d6c8 100644
> > --- a/drivers/net/can/dev/netlink.c
> > +++ b/drivers/net/can/dev/netlink.c
> > @@ -19,6 +19,12 @@ static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] = {
> > [IFLA_CAN_DATA_BITTIMING] = { .len = sizeof(struct can_bittiming) },
> > [IFLA_CAN_DATA_BITTIMING_CONST] = { .len = sizeof(struct can_bittiming_const) },
> > [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
> > + [IFLA_CAN_TDCV] = { .type = NLA_U32 },
> > + [IFLA_CAN_TDCV_MAX_CONST] = { .type = NLA_U32 },
> > + [IFLA_CAN_TDCO] = { .type = NLA_U32 },
> > + [IFLA_CAN_TDCO_MAX_CONST] = { .type = NLA_U32 },
> > + [IFLA_CAN_TDCF] = { .type = NLA_U32 },
> > + [IFLA_CAN_TDCF_MAX_CONST] = { .type = NLA_U32 },
> > };
>
> Looking back at my patch, I just realized that the values are not
> ordered in a consistent way. Here, I alternate between the TDCx
> and the TDCx_CONST...
>
> > (...)
>
> > diff --git a/include/uapi/linux/can/netlink.h b/include/uapi/linux/can/netlink.h
> > index f730d443b918..e69c4b330ae6 100644
> > --- a/include/uapi/linux/can/netlink.h
> > +++ b/include/uapi/linux/can/netlink.h
> > @@ -134,6 +134,12 @@ enum {
> > IFLA_CAN_BITRATE_CONST,
> > IFLA_CAN_DATA_BITRATE_CONST,
> > IFLA_CAN_BITRATE_MAX,
> > + IFLA_CAN_TDCV,
> > + IFLA_CAN_TDCO,
> > + IFLA_CAN_TDCF,
> > + IFLA_CAN_TDCV_MAX_CONST,
> > + IFLA_CAN_TDCO_MAX_CONST,
> > + IFLA_CAN_TDCF_MAX_CONST,
> > __IFLA_CAN_MAX
> > };
>
> ... and there, all the TDCx and the TDCx_CONST are grouped together.
>
> Marc, because the patches are already in the
> linux-can-next/testing, how should I proceed to fix this? Should
> I resend the full patch series with the changes or can I just
> prepare one patch and ask you to squash it?
Please send an incremental patch and I'll squash it.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-09 13:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 0:20 [PATCH v2 0/5] Introducing new CAN FD bittiming parameters: Transmission Delay Compensation (TDC) Vincent Mailhol
2021-02-24 0:20 ` [PATCH v2 1/5] can: add new CAN FD bittiming parameters: Transmitter " Vincent Mailhol
2021-02-24 7:31 ` Marc Kleine-Budde
2021-03-09 8:30 ` Jimmy Assarsson
2021-03-09 8:34 ` Marc Kleine-Budde
2021-03-09 9:09 ` Jimmy Assarsson
2021-06-16 9:54 ` Marc Kleine-Budde
2021-06-16 12:44 ` Vincent MAILHOL
2021-02-24 0:20 ` [PATCH v2 2/5] can: dev: reorder struct can_priv members for better packing Vincent Mailhol
2021-02-24 0:20 ` [PATCH v2 3/5] can: netlink: move '=' operators back to previous line (checkpatch fix) Vincent Mailhol
2021-02-24 0:20 ` [PATCH v2 4/5] can: add netlink interface for CAN-FD Transmitter Delay Compensation (TDC) Vincent Mailhol
2021-03-09 13:16 ` Vincent MAILHOL
2021-03-09 13:19 ` Marc Kleine-Budde [this message]
2021-03-15 15:59 ` Marc Kleine-Budde
2021-03-16 15:16 ` Vincent MAILHOL
2021-03-16 15:29 ` Marc Kleine-Budde
2021-04-05 2:29 ` Vincent MAILHOL
2021-04-07 8:15 ` Marc Kleine-Budde
2021-02-24 0:20 ` [PATCH v2 5/5] can: bittiming: add calculation for CAN FD " Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309131921.7b5jhq3bak2yiv5w@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).