On 09.03.2021 22:10:08, Vincent MAILHOL wrote:
> Sounds good to me. I will prepare a patch to explain the issue
> and try to introduce the dql_set_min_limit() function.
> 
> Meanwhile, I would be thankful if you could continue the review :)

Thanks for the mail, looks good.

One note for the patch, though:

> diff --git a/include/linux/dynamic_queue_limits.h b/include/linux/dynamic_queue_limits.h
> index 407c2f281b64..32437f168a35 100644
> --- a/include/linux/dynamic_queue_limits.h
> +++ b/include/linux/dynamic_queue_limits.h
> @@ -103,6 +103,9 @@ void dql_reset(struct dql *dql);
>  /* Initialize dql state */
>  void dql_init(struct dql *dql, unsigned int hold_time);
>  
> +/* Set the dql minimum limit */
#ifdef CONFIG_DQL
> +void dql_set_min_limit(struct dql *dql, unsigned int min_limit);
#else
static inline void dql_set_min_limit(struct dql *dql, unsigned int min_limit)
{
}
#endif
> +
>  #endif /* _KERNEL_ */
>  
>  #endif /* _LINUX_DQL_H */
> diff --git a/lib/dynamic_queue_limits.c b/lib/dynamic_queue_limits.c
> index fde0aa244148..8b6ad1e0a2e3 100644
> --- a/lib/dynamic_queue_limits.c
> +++ b/lib/dynamic_queue_limits.c

This file is only compiled if CONFIG_DQL is set, see lib/Makefile:

| obj-$(CONFIG_DQL) += dynamic_queue_limits.o

> @@ -136,3 +136,11 @@ void dql_init(struct dql *dql, unsigned int hold_time)
>  	dql_reset(dql);
>  }
>  EXPORT_SYMBOL(dql_init);
> +
> +void dql_set_min_limit(struct dql *dql, unsigned int min_limit)
> +{
> +#ifdef CONFIG_BQL

remove this ifdef

> +	dql->min_limit = min_limit;
> +#endif
> +}
> +EXPORT_SYMBOL(dql_set_min_limit);

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |