On 04.05.2021 12:20:31, Torin Cooper-Bennun wrote: > 1/4 modernises m_can.c, using GENMASK for all regmasks and > FIELD_{GET,PREP,MAX} for ops. Maintainable, consistent and concise. > > 2/4 makes clear all the differences in CCCR between M_CAN spec revisions, > and orders the defs by revision, ascending. > > 3/4 makes explicit the config of RX & TX buffer sizes, making it a bit > more readable, especially against the spec. > > 4/4 fixes whitespace in a few comments. Well done! A really nice cleanup series. Please repost with your Signed-off-by: added. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |