From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E902C433B4 for ; Tue, 4 May 2021 11:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE739611AE for ; Tue, 4 May 2021 11:28:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbhEDL2z (ORCPT ); Tue, 4 May 2021 07:28:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbhEDL2z (ORCPT ); Tue, 4 May 2021 07:28:55 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 951F6C061574 for ; Tue, 4 May 2021 04:28:00 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ldtDa-0006nR-K1; Tue, 04 May 2021 13:27:58 +0200 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:4880:7cee:6dec:c8f9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id DFCA861BBBC; Tue, 4 May 2021 11:27:56 +0000 (UTC) Date: Tue, 4 May 2021 13:27:56 +0200 From: Marc Kleine-Budde To: Torin Cooper-Bennun Cc: linux-can@vger.kernel.org, Pankaj Sharma Subject: Re: PATCH [0/4] can: m_can: various regmask-related cleanup Message-ID: <20210504112756.mqidrskk4mswgxvs@pengutronix.de> References: <20210504112035.336424-1-torin@maxiluxsystems.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mwb5asr2fneawbhu" Content-Disposition: inline In-Reply-To: <20210504112035.336424-1-torin@maxiluxsystems.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org --mwb5asr2fneawbhu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04.05.2021 12:20:31, Torin Cooper-Bennun wrote: > 1/4 modernises m_can.c, using GENMASK for all regmasks and > FIELD_{GET,PREP,MAX} for ops. Maintainable, consistent and concise. >=20 > 2/4 makes clear all the differences in CCCR between M_CAN spec revisions, > and orders the defs by revision, ascending. >=20 > 3/4 makes explicit the config of RX & TX buffer sizes, making it a bit > more readable, especially against the spec. >=20 > 4/4 fixes whitespace in a few comments. Well done! A really nice cleanup series. Please repost with your Signed-off-by: added. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --mwb5asr2fneawbhu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmCRL7kACgkQqclaivrt 76lBDQf+MZUDHZqDFUXGCvGWs6Qfb6JUSNXsjbGdN1NfQPP7xcS4lKLtPHac2Dl+ IWalpq7CojXco3CtfWshSHHRHqg9Vg+6JBjWNI39Nw4+X4UGQG9Qj0CAquaqGYgh F3RgU24DtG1WQZnHGHdrcEW362rc8LkyPEX8x1kmeIg9+vHMMUxxJcYR/JIv14K7 xuks+YVWfCHdlt4hGUOvfNUMYRLwQI/5qD0N5kxyXvV/9xP6HeMmYfUYwpqwMfqa pTBYOwby+QRlMP3E3ukySQEFksuKYk29jnhuhZJLoVrCKCEBwv1fD/9xfLXMhHLY CgqwtJIiyrYR3AysmE3f05NOV9G0wA== =Bjaz -----END PGP SIGNATURE----- --mwb5asr2fneawbhu--