* [PATCH] can: flexcan: flexcan_error_irq_disable(): add missing variable initialization
@ 2021-07-28 7:54 Marc Kleine-Budde
2021-07-28 7:56 ` Marc Kleine-Budde
0 siblings, 1 reply; 3+ messages in thread
From: Marc Kleine-Budde @ 2021-07-28 7:54 UTC (permalink / raw)
To: linux-can; +Cc: Marc Kleine-Budde, kernel test robot, Angelo Dureghello
This patch adds the missing initialization of the "err" variable in
the flexcan_clks_enable() function.
Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
Reported-by: kernel test robot <lkp@intel.com>
Cc: Angelo Dureghello <angelo@kernel-space.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/flexcan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 54ffb796a320..7734229aa078 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -649,7 +649,7 @@ static inline void flexcan_error_irq_disable(const struct flexcan_priv *priv)
static int flexcan_clks_enable(const struct flexcan_priv *priv)
{
- int err;
+ int err = 0;
if (priv->clk_ipg) {
err = clk_prepare_enable(priv->clk_ipg);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] can: flexcan: flexcan_error_irq_disable(): add missing variable initialization
2021-07-28 7:54 [PATCH] can: flexcan: flexcan_error_irq_disable(): add missing variable initialization Marc Kleine-Budde
@ 2021-07-28 7:56 ` Marc Kleine-Budde
2021-07-28 8:02 ` Angelo Dureghello
0 siblings, 1 reply; 3+ messages in thread
From: Marc Kleine-Budde @ 2021-07-28 7:56 UTC (permalink / raw)
To: linux-can; +Cc: Angelo Dureghello
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
The subject is obviously wrong, fixed to "flexcan_clks_enable()".
Marc
On 28.07.2021 09:54:28, Marc Kleine-Budde wrote:
> This patch adds the missing initialization of the "err" variable in
> the flexcan_clks_enable() function.
>
> Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Angelo Dureghello <angelo@kernel-space.org>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> drivers/net/can/flexcan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index 54ffb796a320..7734229aa078 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -649,7 +649,7 @@ static inline void flexcan_error_irq_disable(const struct flexcan_priv *priv)
>
> static int flexcan_clks_enable(const struct flexcan_priv *priv)
> {
> - int err;
> + int err = 0;
>
> if (priv->clk_ipg) {
> err = clk_prepare_enable(priv->clk_ipg);
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: flexcan: flexcan_error_irq_disable(): add missing variable initialization
2021-07-28 7:56 ` Marc Kleine-Budde
@ 2021-07-28 8:02 ` Angelo Dureghello
0 siblings, 0 replies; 3+ messages in thread
From: Angelo Dureghello @ 2021-07-28 8:02 UTC (permalink / raw)
To: Marc Kleine-Budde, linux-can
Hi,
thanks for the fix,
On 28/07/21 9:56 AM, Marc Kleine-Budde wrote:
> The subject is obviously wrong, fixed to "flexcan_clks_enable()".
>
> Marc
>
> On 28.07.2021 09:54:28, Marc Kleine-Budde wrote:
>> This patch adds the missing initialization of the "err" variable in
>> the flexcan_clks_enable() function.
>>
>> Fixes: d9cead75b1c6 ("can: flexcan: add mcf5441x support")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Cc: Angelo Dureghello <angelo@kernel-space.org>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
>> ---
>> drivers/net/can/flexcan.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
>> index 54ffb796a320..7734229aa078 100644
>> --- a/drivers/net/can/flexcan.c
>> +++ b/drivers/net/can/flexcan.c
>> @@ -649,7 +649,7 @@ static inline void flexcan_error_irq_disable(const struct flexcan_priv *priv)
>>
>> static int flexcan_clks_enable(const struct flexcan_priv *priv)
>> {
>> - int err;
>> + int err = 0;
>>
>> if (priv->clk_ipg) {
>> err = clk_prepare_enable(priv->clk_ipg);
>> --
>> 2.30.2
>>
>>
>>
>
regards,
--
Angelo Dureghello
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-28 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 7:54 [PATCH] can: flexcan: flexcan_error_irq_disable(): add missing variable initialization Marc Kleine-Budde
2021-07-28 7:56 ` Marc Kleine-Budde
2021-07-28 8:02 ` Angelo Dureghello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).