On 03.08.2021 16:23:26, Colin Ian King wrote:
> I'm not sure if it's possible for priv->clk_ipg and priv_clk_per to both
> be null, so I'm not sure if err can end up being not set. However, it
> does seem that either err should be zero or some err value, but I was
> unsure how err should be initialized in this corner case. As it stands,
> err probably needs to be set just to be safe.

ACK - There was already a patch that fixes the problem, but I've not
included it in a pull request:

https://lore.kernel.org/linux-can/20210728075428.1493568-1-mkl@pengutronix.de/

Will send now one.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |