From: Matt Kline <matt@bitbashing.io>
To: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Matt Kline <matt@bitbashing.io>, linux-can@vger.kernel.org
Subject: [PATCH v3 0/3] can: m_can: Merge FIFO ops to increase throughput
Date: Mon, 16 Aug 2021 22:08:50 -0700 [thread overview]
Message-ID: <20210817050853.14875-1-matt@bitbashing.io> (raw)
As requested, I've propagated FIFO errors up to the m_can driver - on
failure we now log the error and disable interrupts, similar to
https://elixir.bootlin.com/linux/v5.13/source/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c#L2298
I've also folded the ID and DLC fields into a struct (as suggested) so
that we don't need to copy them to and from arrays for the FIFO transfers.
Following-up on
https://lore.kernel.org/linux-can/20210811063520.aw6hkll2kax22ytr@pengutronix.de/T/#u
Sorry for the slight delay - last week was busy!
Matt Kline (3):
can: m_can: Disable IRQs on FIFO bus errors
can: m_can: Batch FIFO reads during CAN receive
can: m_can: Batch FIFO writes during CAN transmit
drivers/net/can/m_can/m_can.c | 221 ++++++++++++++++---------
drivers/net/can/m_can/m_can.h | 6 +-
drivers/net/can/m_can/m_can_pci.c | 11 +-
drivers/net/can/m_can/m_can_platform.c | 15 +-
drivers/net/can/m_can/tcan4x5x-core.c | 16 +-
5 files changed, 172 insertions(+), 97 deletions(-)
--
2.32.0
next reply other threads:[~2021-08-17 5:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 5:08 Matt Kline [this message]
2021-08-17 5:08 ` [PATCH v3 1/3] can: m_can: Disable IRQs on FIFO bus errors Matt Kline
2021-08-19 11:30 ` Marc Kleine-Budde
2021-08-17 5:08 ` [PATCH v3 2/3] can: m_can: Batch FIFO reads during CAN receive Matt Kline
2021-08-19 11:45 ` Marc Kleine-Budde
2021-09-16 12:04 ` Aswath Govindraju
2021-09-27 8:25 ` Matt Kline
2021-08-17 5:08 ` [PATCH v3 3/3] can: m_can: Batch FIFO writes during CAN transmit Matt Kline
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817050853.14875-1-matt@bitbashing.io \
--to=matt@bitbashing.io \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).