From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Sven Schuchmann <schuchmann@schleissheimer.de>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can: isotp: omit unintended hrtimer restart on socket release
Date: Sun, 29 Aug 2021 22:28:19 +0200 [thread overview]
Message-ID: <20210829202819.tdjkhihpewglytn5@pengutronix.de> (raw)
In-Reply-To: <fa1cac52-73aa-b092-0137-2b1ed734f0ee@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 2109 bytes --]
On 29.08.2021 22:14:41, Oliver Hartkopp wrote:
> > > IMO the issue arises with the use of isotpsend and isotprecv.
> > > These tools are intended to get a hands-on impression how the isotp
> > > stack works.
> > >
> > > This kind of use in a script leads to the creation and (now delayed)
> > > *removal* of isotp sockets for *each* single PDU transfer.
> >
> > Maybe I am wrong but I see something different.
> > e.g. without this patch:
> > (000.000240) canfd0 714 [8] 2B 01 01 01 01 01 01 01
> > (000.000261) canfd0 77E [8] 30 0F 00 AA AA AA AA AA
> > (000.000496) canfd0 714 [8] 2C 01 01 01 01 01 01 01
> >
> > and with this patch:
> > (000.000414) canfd0 714 [8] 2B 01 01 01 01 01 01 01
> > (000.000262) canfd0 77E [8] 30 0F 00 AA AA AA AA AA
> > (000.001536) canfd0 714 [8] 2C 01 01 01 01 01 01 01
> >
>
> I'm running a 5.14.0-rc7-00011-g6e764bcd1cf7 kernel here and see this:
>
> (000.000001) vcan0 714 [8] 2B 01 01 01 01 01 01 01
> (000.000015) vcan0 77E [8] 30 0F 00 AA AA AA AA AA
> (000.000005) vcan0 714 [8] 2C 01 01 01 01 01 01 01
>
> Test iso-tp with 1000 byte frames on vcan0 (data:01)
> 1 / curr: 40 / min: 40 / max: 40 / avg: 40.0
> 2 / curr: 30 / min: 30 / max: 40 / avg: 35.0
> 3 / curr: 35 / min: 30 / max: 40 / avg: 35.0
> 4 / curr: 52 / min: 30 / max: 52 / avg: 39.2
> 5 / curr: 40 / min: 30 / max: 52 / avg: 39.4
> (..)
>
> when running your scripts from the initial post.
>
> Is you canfd0 interface a real hardware?
I can reproduce the issue here, on an embedded system with a real
hardware CAN interface.
In j1939 we make use of rcu so that we don't need the synchronize_net().
Is it possible to use this is ISOTP, too?
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-08-29 20:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 17:37 [PATCH] can: isotp: omit unintended hrtimer restart on socket release Oliver Hartkopp
2021-06-19 21:36 ` Marc Kleine-Budde
2021-08-28 13:20 ` AW: " Sven Schuchmann
2021-08-29 11:17 ` Oliver Hartkopp
2021-08-29 18:28 ` AW: " Sven Schuchmann
2021-08-29 20:14 ` Oliver Hartkopp
2021-08-29 20:28 ` Marc Kleine-Budde [this message]
2021-08-29 21:09 ` AW: " Sven Schuchmann
2021-08-30 7:55 ` Sven Schuchmann
2021-08-30 12:44 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210829202819.tdjkhihpewglytn5@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=schuchmann@schleissheimer.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).