* [PATCH] can: m_can: m_can_platform: Fix the base address in iomap_write_fifo()
@ 2021-09-16 11:21 Aswath Govindraju
2021-09-20 12:36 ` Aswath Govindraju
0 siblings, 1 reply; 2+ messages in thread
From: Aswath Govindraju @ 2021-09-16 11:21 UTC (permalink / raw)
Cc: Lokesh Vutla, Kishon Vijay Abraham I, Aswath Govindraju,
Chandrasekar Ramakrishnan, Wolfgang Grandegger,
Marc Kleine-Budde, David S. Miller, Jakub Kicinski, Matt Kline,
linux-can, netdev, linux-kernel
The write into fifo must be performed with an offset from the message ram
base address. Therefore, fix the base address to mram_base.
Fixes: e39381770ec9 ("can: m_can: Disable IRQs on FIFO bus errors")
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
drivers/net/can/m_can/m_can_platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
index 308d4f2fff00..08eac03ebf2a 100644
--- a/drivers/net/can/m_can/m_can_platform.c
+++ b/drivers/net/can/m_can/m_can_platform.c
@@ -52,7 +52,7 @@ static int iomap_write_fifo(struct m_can_classdev *cdev, int offset,
{
struct m_can_plat_priv *priv = cdev_to_priv(cdev);
- iowrite32_rep(priv->base + offset, val, val_count);
+ iowrite32_rep(priv->mram_base + offset, val, val_count);
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] can: m_can: m_can_platform: Fix the base address in iomap_write_fifo()
2021-09-16 11:21 [PATCH] can: m_can: m_can_platform: Fix the base address in iomap_write_fifo() Aswath Govindraju
@ 2021-09-20 12:36 ` Aswath Govindraju
0 siblings, 0 replies; 2+ messages in thread
From: Aswath Govindraju @ 2021-09-20 12:36 UTC (permalink / raw)
Cc: Lokesh Vutla, Kishon Vijay Abraham I, Chandrasekar Ramakrishnan,
Wolfgang Grandegger, Marc Kleine-Budde, David S. Miller,
Jakub Kicinski, Matt Kline, linux-can, netdev, linux-kernel
Hi all,
On 16/09/21 4:51 pm, Aswath Govindraju wrote:
> The write into fifo must be performed with an offset from the message ram
> base address. Therefore, fix the base address to mram_base.
>
> Fixes: e39381770ec9 ("can: m_can: Disable IRQs on FIFO bus errors")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
This change along with some more fixes are squashed and posted in,
https://patchwork.kernel.org/project/netdevbpf/patch/20210920123344.2320-1-a-govindraju@ti.com/
Thanks,
Aswath
> drivers/net/can/m_can/m_can_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
> index 308d4f2fff00..08eac03ebf2a 100644
> --- a/drivers/net/can/m_can/m_can_platform.c
> +++ b/drivers/net/can/m_can/m_can_platform.c
> @@ -52,7 +52,7 @@ static int iomap_write_fifo(struct m_can_classdev *cdev, int offset,
> {
> struct m_can_plat_priv *priv = cdev_to_priv(cdev);
>
> - iowrite32_rep(priv->base + offset, val, val_count);
> + iowrite32_rep(priv->mram_base + offset, val, val_count);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-20 12:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 11:21 [PATCH] can: m_can: m_can_platform: Fix the base address in iomap_write_fifo() Aswath Govindraju
2021-09-20 12:36 ` Aswath Govindraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).