From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D508C433EF for ; Tue, 17 May 2022 15:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350232AbiEQPiq (ORCPT ); Tue, 17 May 2022 11:38:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350563AbiEQPif (ORCPT ); Tue, 17 May 2022 11:38:35 -0400 Received: from mail.enpas.org (zhong.enpas.org [46.38.239.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C171D50468; Tue, 17 May 2022 08:38:30 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id C621FFF88D; Tue, 17 May 2022 15:38:29 +0000 (UTC) Date: Tue, 17 May 2022 17:38:26 +0200 From: Max Staudt To: Oliver Hartkopp Cc: Marc Kleine-Budde , Vincent MAILHOL , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 3/4] can: skb:: move can_dropped_invalid_skb and can_skb_headroom_valid to skb.c Message-ID: <20220517173821.445c5e90.max@enpas.org> In-Reply-To: <22590a57-c7c6-39c6-06d5-11c6e4e1534b@hartkopp.net> References: <20220513142355.250389-1-mailhol.vincent@wanadoo.fr> <20220514141650.1109542-1-mailhol.vincent@wanadoo.fr> <20220514141650.1109542-4-mailhol.vincent@wanadoo.fr> <7b1644ad-c117-881e-a64f-35b8d8b40ef7@hartkopp.net> <20220517060821.akuqbqxro34tj7x6@pengutronix.de> <20220517104545.eslountqjppvcnz2@pengutronix.de> <20220517141404.578d188a.max@enpas.org> <20220517122153.4r6n6kkbdslsa2hv@pengutronix.de> <20220517143921.08458f2c.max@enpas.org> <0b505b1f-1ee4-5a2c-3bbf-6e9822f78817@hartkopp.net> <20220517154301.5bf99ba9.max@enpas.org> <22590a57-c7c6-39c6-06d5-11c6e4e1534b@hartkopp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Tue, 17 May 2022 16:35:05 +0200 Oliver Hartkopp wrote: > I think it should be even more simple. > > When you enter the current Kconfig page of "CAN Device Drivers" every > selection of vcan/vxcan/slcan should directly select CAN_DEV_SW. I'm a bit lost - what would CAN_DEV_SW do? If it enables can_dropped_invalid_skb(), then the HW drivers would also need to depend on CAN_DEV_SW directly or indirectly, or am I missing something? Max