linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	linux-can@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH net 0/17] pull-request: can 2022-09-20
Date: Tue, 20 Sep 2022 21:27:08 +0200	[thread overview]
Message-ID: <20220920192708.jcvyph3ec7lscuqj@pengutronix.de> (raw)
In-Reply-To: <20220920122246.00dbe946@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

On 20.09.2022 12:22:46, Jakub Kicinski wrote:
> On Tue, 20 Sep 2022 11:28:58 +0200 Marc Kleine-Budde wrote:
> > The next 15 patches are by Anssi Hannula and Jimmy Assarsson and fix
> > various problem in the kvaser_usb CAN driver.
> 
> These are large patches which don't clearly justify the classification
> as a fix. Patches 6 and 8 for example leave me asking "what does this
> fix?" It's good to report errors, but the absence of error reporting
> is not necessarily a bug worthy of stable.
> 
> Can we get the commit messages beefed up?

I'll talk to the authors, try to get better commit messages and distill
the minimum patches the need to be ported to stable.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2022-09-20 19:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  9:28 [PATCH net 0/17] pull-request: can 2022-09-20 Marc Kleine-Budde
2022-09-20  9:28 ` [PATCH net 01/17] can: flexcan: flexcan_mailbox_read() fix return value for drop = true Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 02/17] can: gs_usb: gs_usb_set_phys_id(): return with error if identify is not supported Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 03/17] can: kvaser_usb_leaf: Fix overread with an invalid command Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 04/17] can: kvaser_usb: Fix use of uninitialized completion Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 05/17] can: kvaser_usb: Fix possible completions during init_completion Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 06/17] can: kvaser_usb: kvaser_usb_leaf: Get capabilities from device Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 07/17] can: kvaser_usb: kvaser_usb_leaf: Rename {leaf,usbcan}_cmd_error_event to {leaf,usbcan}_cmd_can_error_event Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 08/17] can: kvaser_usb: kvaser_usb_leaf: Handle CMD_ERROR_EVENT Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 09/17] can: kvaser_usb_leaf: Set Warning state even without bus errors Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 10/17] can: kvaser_usb_leaf: Fix TX queue out of sync after restart Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 11/17] can: kvaser_usb_leaf: Fix CAN state " Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 12/17] can: kvaser_usb_leaf: Fix improved state not being reported Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 13/17] can: kvaser_usb_leaf: Fix wrong CAN state after stopping Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 14/17] can: kvaser_usb_leaf: Ignore stale bus-off after start Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 15/17] can: kvaser_usb_leaf: Fix bogus restart events Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 16/17] can: kvaser_usb: Add struct kvaser_usb_busparams Marc Kleine-Budde
2022-09-20  9:29 ` [PATCH net 17/17] can: kvaser_usb: Compare requested bittiming parameters with actual parameters in do_set_{,data}_bittiming Marc Kleine-Budde
2022-09-20 19:22 ` [PATCH net 0/17] pull-request: can 2022-09-20 Jakub Kicinski
2022-09-20 19:27   ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220920192708.jcvyph3ec7lscuqj@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=davem@davemloft.net \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).