From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B89CAC4332F for ; Sun, 13 Nov 2022 13:03:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232799AbiKMNDj (ORCPT ); Sun, 13 Nov 2022 08:03:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235291AbiKMNDh (ORCPT ); Sun, 13 Nov 2022 08:03:37 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5A62BEC for ; Sun, 13 Nov 2022 05:03:36 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouCe7-0000z8-7t; Sun, 13 Nov 2022 14:03:35 +0100 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:6d7d:dd1c:b670:c511]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 6400411BDA3; Sun, 13 Nov 2022 13:03:34 +0000 (UTC) Date: Sun, 13 Nov 2022 14:03:25 +0100 From: Marc Kleine-Budde To: Vincent Mailhol Cc: linux-can@vger.kernel.org, Oliver Hartkopp Subject: Re: [PATCH can-utils-dev 2/5] lib: add pr_debug() macro Message-ID: <20221113130325.5tagqsi4t4523uob@pengutronix.de> References: <20221113085321.87910-1-mailhol.vincent@wanadoo.fr> <20221113085321.87910-3-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j2pvyayd5zv647a2" Content-Disposition: inline In-Reply-To: <20221113085321.87910-3-mailhol.vincent@wanadoo.fr> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org --j2pvyayd5zv647a2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 13.11.2022 17:53:18, Vincent Mailhol wrote: > diff --git a/mcp251xfd/mcp251xfd-dev-coredump.c b/mcp251xfd/mcp251xfd-dev= -coredump.c > index 5874d24..422900f 100644 > --- a/mcp251xfd/mcp251xfd-dev-coredump.c > +++ b/mcp251xfd/mcp251xfd-dev-coredump.c > @@ -17,18 +17,10 @@ > =20 > #include > =20 > +#include "../lib.h" Does #include work? > #include "mcp251xfd.h" > #include "mcp251xfd-dump-userspace.h" > =20 > -#define pr_err(fmt, args...) fprintf(stderr, fmt, ##args) > -#define pr_no(fmt, args...) while (0) { fprintf(stdout, fmt, ##args)= ; } > - > -#ifdef DEBUG > -#define pr_debug(fmt, args...) pr_err(fmt, ##args) > -#else > -#define pr_debug(fmt, args...) pr_no(fmt, ##args) > -#endif > - > =20 > struct mcp251xfd_dump_iter { > const void *start; Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --j2pvyayd5zv647a2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmNw6xsACgkQrX5LkNig 013Rfgf/XvEEEd/UYJrgxMiOrHwXl1JEYoK9sJnPVePoVDTuovYmFmh3386DzKnP 0k5Q9kpUSSzT9Hzuxjc7C4LKczMuskYmz/yGfJztMgRp7cRHG7GTw8Q3BSE8UPM4 6envALZIcu41h7ofhqCF4t4DiqusLpM1NtGcrVqZBGRFJsVnZXYZi6q6dWWEbbCD L0245MmusKCZGubhCkm0oTlu8RF7Zdedd2KfJOVcuo/lLkWt5QvYq4yTmZgYmHLP OuaheYCMvCLOvZzm8Z6QSGAwpfr7H/dnvCMjw1+aTGf3Sq7PMsJqmBLimtdl3TsR bU+9bWD9hvC4e+3xOrditmQmk6JqkA== =dR3u -----END PGP SIGNATURE----- --j2pvyayd5zv647a2--