From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB4EC77B7A for ; Tue, 16 May 2023 08:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231388AbjEPI5G (ORCPT ); Tue, 16 May 2023 04:57:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230408AbjEPI5G (ORCPT ); Tue, 16 May 2023 04:57:06 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BDFD2702 for ; Tue, 16 May 2023 01:57:05 -0700 (PDT) Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyqTl-0003Fb-MX; Tue, 16 May 2023 10:56:21 +0200 Received: from pengutronix.de (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 823541C6306; Tue, 16 May 2023 08:56:17 +0000 (UTC) Date: Tue, 16 May 2023 10:56:17 +0200 From: Marc Kleine-Budde To: Simon Horman Cc: Alexandre Belloni , Jernej Skrabec , Geert Uytterhoeven , Zhang Changzhong , Eric Dumazet , Haibo Chen , Dario Binacchi , Rob Herring , Samuel Holland , Minghao Chi , Chen-Yu Tsai , Dongliang Mu , linux-arm-kernel@lists.infradead.org, Yang Yingliang , Jakub Kicinski , Paolo Abeni , linux-sunxi@lists.linux.dev, Wolfgang Grandegger , Pavel Pisa , Naga Sureshkumar Relli , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linux-can@vger.kernel.org, Chris Packham , Wei Fang , Appana Durga Kedareswara rao , Biju Das , Andy Shevchenko , Michal Simek , Vincent Mailhol , Chandrasekar Ramakrishnan , Oliver Hartkopp , Nicolas Ferre , "David S. Miller" , Wolfram Sang , Ondrej Ille , Mark Brown , kernel@pengutronix.de, netdev@vger.kernel.org, Christophe JAILLET , Claudiu Beznea Subject: Re: [PATCH net-next 00/19] can: Convert to platform remove callback returning void Message-ID: <20230516-cresting-anaconda-07c5ff1412ed-mkl@pengutronix.de> References: <20230512212725.143824-1-u.kleine-koenig@pengutronix.de> <20230516-sharply-sulphuric-2c99e8c1cbda-mkl@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="buls3nqvfcme3fto" Content-Disposition: inline In-Reply-To: <20230516-sharply-sulphuric-2c99e8c1cbda-mkl@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:b01:1d::7b X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org --buls3nqvfcme3fto Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 16.05.2023 10:54:06, Marc Kleine-Budde wrote: > On 16.05.2023 10:45:23, Simon Horman wrote: > > On Tue, May 16, 2023 at 09:31:04AM +0200, Simon Horman wrote: > > > On Fri, May 12, 2023 at 11:27:06PM +0200, Uwe Kleine-K=C3=B6nig wrote: > > > > Hello, > > > >=20 > > > > this series convers the drivers below drivers/net/can to the > > > > .remove_new() callback of struct platform_driver(). The motivation = is to > > > > make the remove callback less prone for errors and wrong assumption= s. > > > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > > > > returns no value") for a more detailed rationale. > > > >=20 > > > > All drivers already returned zero unconditionally in their > > > > .remove() callback, so converting them to .remove_new() is trivial. > > >=20 > > > Hi Uwe, > > >=20 > > > I like these changes and they all look good to me. > > > However, I have a question, perhaps more directed at the netdev > > > maintainers than yourself. > > >=20 > > > In principle patch-sets for netdev should not include more than 15 pa= tches. > > > It's unclear to me if, on the basis of that, this patchset should > > > be split up. Or if, f.e. given the simple nature of the patches, > > > an exception applies in this case. Or something else. > > >=20 > > > I have no fixed opinion on this. > > > But I feel that the question should be asked. > > >=20 > > > Link: https://kernel.org/doc/html/v6.1/process/maintainer-netdev.html > > >=20 > > > ... > >=20 > > I now realise this series is for can. > > Which I assume means the guidance above doesn't apply. > >=20 > > Sorry for the noise. >=20 > That's still a good point, because sooner or later Uwe will probably > also convert the platform drivers to Driver/Network/Ethernet. =2E..in driver/net/ethernet. (damnyouautocorrect) Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --buls3nqvfcme3fto Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmRjRSwACgkQvlAcSiqK BOgpFgf/clqhhNylGlVnHL52KfOeawTcsln5X1etmr1JkJUTACGJNgqBtVd/2MwZ 5F53qnKrEiB329WeGNLy7/ebiGKMEes8gHzmxVagn+nKgeYHfpMqjjWI/S5Ed76k dHtngo9juS8SYIKK3d8H651SMg1S/J6+UkNlXtWs0jNznBQQsIje927pCQs5Zsn4 dtf5cg3WZDaQc+KXjbFkSo3N390ViYCzwDq6Xs/gPfjdJEWhXVlcwAjTuDw0e1Ot TfLffOGUHZNLUaC2s7UYy43lEdfEHChQ8U9Db/HPZ4MGHkflZ4ywiZ75FZl80Iwn KMsaxUzR+12+ASzieFSRPKwr0G2jEQ== =t1JR -----END PGP SIGNATURE----- --buls3nqvfcme3fto--