From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18785C433F5 for ; Mon, 20 Sep 2021 12:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F392A60F48 for ; Mon, 20 Sep 2021 12:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233898AbhITMiN (ORCPT ); Mon, 20 Sep 2021 08:38:13 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:58674 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231849AbhITMiN (ORCPT ); Mon, 20 Sep 2021 08:38:13 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 18KCaX7h059943; Mon, 20 Sep 2021 07:36:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1632141393; bh=VG1KVcz3GSfRISR4WxwHrhgZOlkDTvXLPDBDHCoKw1E=; h=Subject:CC:References:From:Date:In-Reply-To; b=Ixpx+xOyWA/pfavocAesc4Dti/V8cdAKvs+lhDjelRI8tkJdJtGO6KgcElxRsXUzL jdLhhCDiSD7cgDYr88fvV5F36LIRRaOWRjj8xkQrGhl/I3mKrgqhvlwoh5HQuhJ4kl 11idu5B298dm28f0oS5lkBKbD5M2x2x+Rh09Q2p4= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 18KCaXks015872 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 20 Sep 2021 07:36:33 -0500 Received: from DFLE103.ent.ti.com (10.64.6.24) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Mon, 20 Sep 2021 07:36:33 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Mon, 20 Sep 2021 07:36:33 -0500 Received: from [10.250.232.51] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 18KCaTVn024063; Mon, 20 Sep 2021 07:36:30 -0500 Subject: Re: [PATCH] can: m_can: m_can_platform: Fix the base address in iomap_write_fifo() CC: Lokesh Vutla , Kishon Vijay Abraham I , Chandrasekar Ramakrishnan , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Matt Kline , , , References: <20210916112151.26494-1-a-govindraju@ti.com> From: Aswath Govindraju Message-ID: <2d069fd4-fc98-f1ce-7f26-c3e2569e7efa@ti.com> Date: Mon, 20 Sep 2021 18:06:28 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210916112151.26494-1-a-govindraju@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi all, On 16/09/21 4:51 pm, Aswath Govindraju wrote: > The write into fifo must be performed with an offset from the message ram > base address. Therefore, fix the base address to mram_base. > > Fixes: e39381770ec9 ("can: m_can: Disable IRQs on FIFO bus errors") > Signed-off-by: Aswath Govindraju > --- This change along with some more fixes are squashed and posted in, https://patchwork.kernel.org/project/netdevbpf/patch/20210920123344.2320-1-a-govindraju@ti.com/ Thanks, Aswath > drivers/net/can/m_can/m_can_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c > index 308d4f2fff00..08eac03ebf2a 100644 > --- a/drivers/net/can/m_can/m_can_platform.c > +++ b/drivers/net/can/m_can/m_can_platform.c > @@ -52,7 +52,7 @@ static int iomap_write_fifo(struct m_can_classdev *cdev, int offset, > { > struct m_can_plat_priv *priv = cdev_to_priv(cdev); > > - iowrite32_rep(priv->base + offset, val, val_count); > + iowrite32_rep(priv->mram_base + offset, val, val_count); > > return 0; > } >