On 11/04/2014 02:24 PM, Oliver Hartkopp wrote: > Hello Thomas, > > looks far better to me now. Thanks. > > @Marc: The only two questions I would have is this pretty short commit > message and the module parameter. > What do you think about it (and the rest)? Yes, the commit message should be a bit more verbose. And the module parameter should probably be removed. I'm currently reviewing Stefano Babic's SPI driver, which has been waiting for review a bit longer. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |