From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AECECCA479 for ; Mon, 4 Jul 2022 15:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234766AbiGDPIX (ORCPT ); Mon, 4 Jul 2022 11:08:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235023AbiGDPHy (ORCPT ); Mon, 4 Jul 2022 11:07:54 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2AB211148 for ; Mon, 4 Jul 2022 08:06:57 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id c12so1486190lff.2 for ; Mon, 04 Jul 2022 08:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kvaser.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=PsBtHpMy5uXbzB8lQXz0O4ljYPlSjSFx7+ITMI5I+k4=; b=iDr+ves6KwXdx6kwvxF0OHsV7sQR51hDU6nL0DhVwTIm66romjSo+HVJTFsg34JQQG bbjBCx7I6EN6/bET2XvqMCyjeiA0m6Ny29na9Rt6aXiJ5yQWYVAtFA2kvKCZrJpQer+X il7kSCH0O0z6hSS+sON2uZ3KOV0eS3/h8WZCSsjMpN2I9J//11iNCm4HhHzT39p1pbO2 u2gnTQhwC3LCxrYdGfjL+9PUJx3tUBWq65etISsOQAqTwvd3enQg363eky5hQlZEuke/ bDiFbJ0su0iMZb3IlItWzfztHoGMT2VApEBSDzCL7x6ml+hPXllWFxIuTOKRZgo0Fpfi iAVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=PsBtHpMy5uXbzB8lQXz0O4ljYPlSjSFx7+ITMI5I+k4=; b=uqcnyV/fNSVfduN/GBzRq8qv0YM7GTTNhGytHveBmqUPo2Hld6lbR8USqkF3Qj5pJd bcgvesFzrSSRJ9NvdGBu0zqNye5VgOgKe/HnJ53zPzjogDksOleU17nJBEoz1k3njsnZ zjaR94m3vfkc7UVLZgBlVFUGa9uWhYtDN0CFLgGXttFButrxQmjmpvWZkWRgJRYJ+CsG acY9VIob1mUXlxnCsDRacDfKJl0to9H1hPHbgMzy3Gl3bnxtPleTQOmgfygXau7xcn4x 04cY4XjFPHvWmD/bHouU2Du7TdAnb750TjmnqJVUWJbn54QdX1JZx7uRaEtaexJQ27ih eOwg== X-Gm-Message-State: AJIora9T4xS6EUrPzAzvRfHCCG47pEsBXQPVwLch2t2xmHk2MUMrC0eG oz0m+pY8MDn+9CyoKGKrkUiJVQ== X-Google-Smtp-Source: AGRyM1s2oQBCaEnNr3OBe9rDORvEdR2sDiB5OOWkRvQ5aU69AT/EctYaJYARM1BSFTuPGf6cTjOvow== X-Received: by 2002:ac2:5ec9:0:b0:481:16ae:5a55 with SMTP id d9-20020ac25ec9000000b0048116ae5a55mr20001113lfq.678.1656947215789; Mon, 04 Jul 2022 08:06:55 -0700 (PDT) Received: from [192.168.16.142] (h-155-4-68-234.A785.priv.bahnhof.se. [155.4.68.234]) by smtp.gmail.com with ESMTPSA id y9-20020ac24e69000000b0047f647414efsm5173735lfs.190.2022.07.04.08.06.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 08:06:55 -0700 (PDT) Message-ID: <612195b5-aca0-2902-66f8-7d9a4f33c4dd@kvaser.com> Date: Mon, 4 Jul 2022 17:07:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2 0/3] can: kvaser_usb: CAN clock frequency regression Content-Language: en-US To: Marc Kleine-Budde Cc: linux-can@vger.kernel.org, Jimmy Assarsson , stable@vger.kernel.org References: <20220603083820.800246-1-extja@kvaser.com> <20220704130742.aeczqfbfnwemb7ax@pengutronix.de> From: Jimmy Assarsson In-Reply-To: <20220704130742.aeczqfbfnwemb7ax@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On 7/4/22 15:07, Marc Kleine-Budde wrote: > On 03.06.2022 10:38:17, Jimmy Assarsson wrote: >> When fixing the CAN clock frequency, >> fb12797ab1fe ("can: kvaser_usb: get CAN clock frequency from device"), >> I introduced a regression. >> >> For Leaf devices based on M32C, the firmware expects bittiming parameters >> calculated for 16MHz clock. Regardless of the actual clock frequency. >> >> This regression affects M32C based Leaf devices with non-16MHz clock. >> >> Also correct the bittiming constants in kvaser_usb_leaf.c, where the limits >> are different depending on which firmware/device being used. >> >> Once merged to mainline, I'll backport these fixes for the stable kernels. > > Added to linux-can/testing. I had to move the kvaser_usb_driver_info > into kvaser_usb_core.c and the keep struct can_bittiming_const > kvaser_usb_flexc_bittiming_const in kvaser_usb_hydra.c as structs in > header files cause defined but not used warnings on some platforms. Ok. Thanks Marc!